Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: IntegrationTests: TestTimer_ExitOnCloseFnCtx: panic: close of closed channel #25177

Closed
christarazi opened this issue Apr 27, 2023 · 1 comment · Fixed by #25211
Closed

CI: IntegrationTests: TestTimer_ExitOnCloseFnCtx: panic: close of closed channel #25177

christarazi opened this issue Apr 27, 2023 · 1 comment · Fixed by #25211
Assignees
@dylandreimerink
Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me!

Comments

@christarazi
Copy link
Member

CI failure

┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓                                                                                
┃   PANIC  package: github.com/cilium/cilium/pkg/hive/job • TestTimer_ExitOnCloseFnCtx   ┃                                                                                
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛                                                                                
panic: close of closed channel                                                                                                                                            
                                                                                                                                                                          
goroutine 79 [running]:                                                                                                                                                   
github.com/cilium/cilium/pkg/hive/job.TestTimer_ExitOnCloseFnCtx.func1.1({0x92c800, 0xc00023af90})                                                                        
	/home/runner/work/cilium/cilium/pkg/hive/job/job_test.go:577 +0x31                                                                                                        
github.com/cilium/cilium/pkg/hive/job.(*jobTimer).start(0xc000201220, {0x92c800, 0xc00023af90}, 0x8c0b60?, {{{0x0, 0x0, 0x0}}, {0x930458, 0xc000177420}, {0x928fc0, ...}})
	/home/runner/work/cilium/cilium/pkg/hive/job/job.go:393 +0x4a3                                                                                                            
created by github.com/cilium/cilium/pkg/hive/job.(*group).Start.func1                                                                                                     
	/home/runner/work/cilium/cilium/pkg/hive/job/job.go:137 +0x158                                                                                                            
FAIL	github.com/cilium/cilium/pkg/hive/job	17.427s

https://github.com/cilium/cilium/actions/runs/4824725040/jobs/8594843070
@christarazi christarazi added area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Apr 27, 2023
@christarazi christarazi mentioned this issue Apr 27, 2023
Merged
@christarazi
Copy link
Member Author

@dylandreimerink Seems like a flake introduced by #24558.

@dylandreimerink dylandreimerink self-assigned this Apr 29, 2023
dylandreimerink added a commit to dylandreimerink/cilium that referenced this issue Apr 29, 2023
@dylandreimerink
jobs,test: Fix TestTimer_ExitOnCloseFnCtx channel close panic
8b91ce5 
This test enforces that a timer callback will not be called after the
context has been canceled. However, it was written such that if the test
fails a panic is thrown. This fixes both the panic-on-fail and resolves
the edge case causing the flake.

Fixes: cilium#25177

Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
@dylandreimerink dylandreimerink mentioned this issue Apr 29, 2023
Merged
@joestringer joestringer mentioned this issue May 5, 2023
Closed
joestringer pushed a commit that referenced this issue May 5, 2023
@dylandreimerink @joestringer
jobs,test: Fix TestTimer_ExitOnCloseFnCtx channel close panic
daa85a0 
This test enforces that a timer callback will not be called after the
context has been canceled. However, it was written such that if the test
fails a panic is thrown. This fixes both the panic-on-fail and resolves
the edge case causing the flake.

Fixes: #25177

Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylandreimerink dylandreimerink

Labels
area/CI Continuous Integration testing issue or flake ci/flake This is a known failure that occurs in the tree. Please investigate me!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jobs,test: Fix TestTimer_ExitOnCloseFnCtx channel close panic dylandreimerink/cilium
2 participants
@dylandreimerink @christarazi