Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm chart for hubble-ui deployment removed nodeSelector and tolerations on 1.11.15 release #25181

Closed
2 tasks done
BryanStenson-okta opened this issue Apr 28, 2023 · 2 comments · Fixed by #25182
Closed
2 tasks done

helm chart for hubble-ui deployment removed nodeSelector and tolerations on 1.11.15 release #25181

BryanStenson-okta opened this issue Apr 28, 2023 · 2 comments · Fixed by #25182
Labels
area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. sig/agent Cilium agent related. sig/hubble Impacts hubble server or relay stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.

Comments

@BryanStenson-okta
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

This PR removed nodeSelector and toleration settings for the hubble-ui deployment.

The current 1.11 branch (1.11.16) values.yaml seems to suggest this was a mistake, as there are defaults listed: https://github.com/cilium/cilium/blob/v1.11.16/install/kubernetes/cilium/values.yaml#L939-L946

Cilium Version

1.11.15

Kernel Version

n/a

Kubernetes Version

1.25

Sysdump

No response

Relevant log output

No response

Anything else?

Unless this was intentional, I can put a PR to revert.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@BryanStenson-okta BryanStenson-okta added kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. needs/triage This issue requires triaging to establish severity and next steps. labels Apr 28, 2023
@BryanStenson-okta BryanStenson-okta changed the title helm chart for hubble-ui removed nodeSelector and tolerations on 1.11.15 release helm chart for hubble-ui deployment removed nodeSelector and tolerations on 1.11.15 release Apr 28, 2023
@BryanStenson-okta BryanStenson-okta mentioned this issue Apr 28, 2023
Merged
@aanm aanm added kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. area/helm Impacts helm charts and user deployment experience and removed needs/triage This issue requires triaging to establish severity and next steps. labels Apr 28, 2023
@youngnick youngnick added sig/hubble Impacts hubble server or relay sig/agent Cilium agent related. labels May 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jul 8, 2023
@rolinh
Copy link
Member

rolinh commented Jul 10, 2023

This issue has been fixed by #25182.

@rolinh rolinh closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic. kind/community-report This was reported by a user in the Cilium community, eg via Slack. kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. sig/agent Cilium agent related. sig/hubble Impacts hubble server or relay stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
None yet
Milestone
No milestone
4 participants
@rolinh @aanm @youngnick @BryanStenson-okta