Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.11] helm chart: v1.11 base : hubble-ui deployment : restore nodeSelector and tolerations #25182

Conversation

BryanStenson-okta
Copy link
Contributor

Fixes: #25181

helm chart: restore setting nodeSelector and tolerations on hubble-ui deployment via `values.yaml`

@BryanStenson-okta BryanStenson-okta requested review from a team as code owners April 28, 2023 04:52
@BryanStenson-okta BryanStenson-okta force-pushed the restore-nodeselector-and-tolerations branch from feaf410 to 388d736 Compare May 5, 2023 17:19
@maintainer-s-little-helper
Copy link

Commit 388d736fa6c72c9263bd190ad570409f52f2b841 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 5, 2023
@BryanStenson-okta BryanStenson-okta force-pushed the restore-nodeselector-and-tolerations branch from 388d736 to 17d190b Compare May 5, 2023 17:20
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 5, 2023
@BryanStenson-okta BryanStenson-okta force-pushed the restore-nodeselector-and-tolerations branch from 17d190b to 375859e Compare May 5, 2023 17:35
@joestringer
Copy link
Member

/test

@joestringer
Copy link
Member

It looks like the test runs are not picking up the correct jobs, as the latest version is not rebased against the latest version of main. You may need to do a git fetch origin and/or git pull --rebase in order to resolve this.

@BryanStenson-okta
Copy link
Contributor Author

BryanStenson-okta commented May 5, 2023

rebase on main, or v1.11? i think i'm confused on the release process for what would be a v1.11.17 release.

i had rebased on the HEAD from v1.11 branch. maybe that's not what i should have done here.

@gandro
Copy link
Member

gandro commented May 8, 2023

I think the tests are failing because we ran the wrong trigger. /test is supposed to run against main, but this is a backport PR targeting v1.11.

@gandro gandro changed the title helm chart: v1.11 base : hubble-ui deployment : restore nodeSelector and tolerations [v1.11] helm chart: v1.11 base : hubble-ui deployment : restore nodeSelector and tolerations May 8, 2023
@gandro gandro added backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. and removed dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. labels May 8, 2023
@gandro
Copy link
Member

gandro commented May 8, 2023

/test-backport-1.11

Job 'Cilium-PR-K8s-1.19-kernel-4.9' failed:

Click to show.

Test Name

K8sServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) Checks service on same node

Failure Output

FAIL: Found 2 k8s-app=cilium logs matching list of errors that must be investigated:

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-4.9/2852/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.19-kernel-4.9 so I can create one.

Then please upload the Jenkins artifacts to that issue.

Job 'Cilium-PR-K8s-1.21-kernel-4.9' has 1 failure but they might be new flake since it also hit 1 known flake: #22555 (94.08% similarity)

Job 'Cilium-PR-K8s-1.17-kernel-4.9' hit: #22555 (92.92% similarity)

@jrajahalme
Copy link
Member

/ci-l4lb-1.11

…and tolerations

Signed-off-by: Bryan Stenson <bryan.stenson@okta.com>
@BryanStenson-okta BryanStenson-okta force-pushed the restore-nodeselector-and-tolerations branch from 375859e to 9894ea7 Compare May 11, 2023 15:29
@jrajahalme
Copy link
Member

jrajahalme commented May 12, 2023

/test-backport-1.11

Job 'Cilium-PR-K8s-1.22-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathConfig Host firewall With VXLAN

Failure Output

FAIL: Failed to reach 192.168.56.11:80 from testclient-7sphr

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.22-kernel-4.19/1677/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.22-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

Job 'Cilium-PR-K8s-1.21-kernel-4.9' failed:

Click to show.

Test Name

K8sKafkaPolicyTest Kafka Policy Tests KafkaPolicies

Failure Output

FAIL: Found 2 k8s-app=cilium logs matching list of errors that must be investigated:

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.21-kernel-4.9/2636/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.21-kernel-4.9 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@jrajahalme
Copy link
Member

test-1.22-4.19 hit known flake #16122,
test-1.21-4.9 hit known flake #24394

@jrajahalme
Copy link
Member

/ci-l4lb-1.11

@jrajahalme
Copy link
Member

ci-l4lb-1.11 does not trigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/community-contribution This was a contribution made by a community member. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm chart for hubble-ui deployment removed nodeSelector and tolerations on 1.11.15 release
10 participants