gh/workflows: Use cilium-cli GHA to install CLI exec #25228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
area/CI-improvement
brb
force-pushed
the
pr/brb/gh-install-cli
branch
4 times, most recently
from
5286297
to
fbd6c8b
Compare
brb
force-pushed
the
pr/brb/gh-install-cli
branch
3 times, most recently
from
ba288c8
to
5125666
Compare
brb
changed the title
brb
force-pushed
the
pr/brb/gh-install-cli
branch
2 times, most recently
from
bbb556b
to
8f08c42
Compare
aanm
requested changes
May 3, 2023
brb
force-pushed
the
pr/brb/gh-install-cli
branch
3 times, most recently
from
873bbb0
to
a483cb0
Compare
tklauser
reviewed
May 4, 2023
| @@ -72,6 +72,7 @@ env: | |||
| k8s_version: 1.23 | |||
| # renovate: datasource=github-releases depName=cilium/cilium-cli | |||
| cilium_cli_version: v0.13.2 | |||
| cilium_cli_ci_version: | |||
There was a problem hiding this comment.
Do we really need to set this in every workflow? Can't we just keep with.relase-version when using the action below and rely on the with.ci-version default value being empty?
There was a problem hiding this comment.
It's to make sed'ing easier (described in the description). I'd like to avoid setting it too, but didn't come up with any nice solution.
tklauser
approved these changes
May 4, 2023
brb
added
the
ready-to-merge
nebril
approved these changes
May 4, 2023
joestringer
removed
the
ready-to-merge
|
Removed ready-to-merge pending resolution of #25228 (comment) . |
This reduces not only the boilerplate, but allows with a few cmds to
change the CLI vsn to test WIP changes. For example, to use a custom CLI
CI build for all workflows:
$ CI_BUILD_VSN=foobar # Docker Image Version of CI Cilium CLI
$ git grep -l cilium_cli_version: | xargs sed -i 's/cilium_cli_version: .*/cilium_cli_version:/g'
$ git grep -l cilium_cli_ci_version: | xargs sed -i 's/cilium_cli_ci_version: .*/cilium_cli_ci_version: $CI_BUILD_VSN/g'
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@joestringer The comment has been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces not only the boilerplate, but allows with a few cmds to change the CLI vsn to test WIP changes. For example, to use a custom CLI CI build for all workflows:
Depends on cilium/cilium-cli#1563