Use cli-based Helm install for tests-smoke conformance workflow
#25493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
bleggett
changed the title
tests-smoke conformance workflow
nbusseneau
added
area/CI-improvement
|
Thanks, I've converted this to draft so you can iterate, don't hesitate to mark as ready for review when you feel you are ready for a first look :) |
bleggett
force-pushed
the
bleggett/helm-conformance-smoke
branch
9 times, most recently
from
e73d646
to
7d4dc09
Compare
bleggett
changed the title
tests-smoke conformance workflowtests-smoke conformance workflow
|
@nbusseneau ready for a look when you are, ty |
15 tasks
bleggett
force-pushed
the
bleggett/helm-conformance-smoke
branch
from
7d4dc09
to
04fad60
Compare
nbusseneau
requested changes
May 26, 2023
Signed-off-by: Benjamin Leggett <benjamin.leggett@solo.io>
bleggett
force-pushed
the
bleggett/helm-conformance-smoke
branch
from
888b774
to
92b88b1
Compare
TY! Fixed. |
nbusseneau
added
the
ready-to-merge
|
Smoke tests passed and this PR does not need any other CI, marking ready to merge. |
joestringer
reviewed
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
conformance-smokeworkflow to helm install mode, in an effort to knock one of the line items off of: #25156This is a small change for the most part since these tests already used Helm, just not via
cilium-cliproper.actisn't cooperating so I'm leaning on CI for troubleshooting, I expect it to fail.