Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Remove deprecated hubble.tls.ca #25261

Merged
merged 1 commit into from May 23, 2023
Merged

helm: Remove deprecated hubble.tls.ca #25261

merged 1 commit into from May 23, 2023

Conversation

ysksuzuki
Copy link
Member

@ysksuzuki ysksuzuki commented May 4, 2023 •
edited

hubble.tls.ca has been removed but but it's still being referenced. This commit cleans up those references.

follow-up of 0fd3945

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

@ysksuzuki ysksuzuki requested review from a team as code owners May 4, 2023 14:18
@ysksuzuki ysksuzuki requested review from youngnick and gandro May 4, 2023 14:18
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 4, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 4, 2023
@giorio94 giorio94 requested a review from qmonnet May 4, 2023 14:26
@qmonnet qmonnet added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience release-blocker/1.14 This issue will prevent the release of the next version of Cilium. labels May 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 5, 2023
qmonnet
qmonnet approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, thanks for catching this and fixing it!

Given that it fixes an issue with the Helm charts that we recently introduced, it would be great to have this in before the next release. I'm marking as release blocker.

@qmonnet qmonnet removed the request for review from zacharysarah May 5, 2023 08:27
@ysksuzuki
Copy link
Member Author

It seems that Chart CI push has been fixed by #25274

@ysksuzuki
helm: Remove deprecated hubble.tls.ca
c3a9647 
hubble.tls.ca has been removed but it's still being referenced.
This commit cleans up those references.

follow-up of 0fd3945

Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
@qmonnet
Copy link
Member

qmonnet commented May 5, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks N/S loadbalancing With host policy Tests NodePort

Failure Output

FAIL: Can not connect to service "tftp://192.168.56.12:30270/hello" from outside cluster (1/10)

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2108/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@ysksuzuki
Copy link
Member Author

Hit the flake #15455

@ysksuzuki
Copy link
Member Author

ysksuzuki commented May 5, 2023 •
edited by maintainer-s-little-helper bot

/test-1.26-net-next

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks N/S loadbalancing Tests with XDP, direct routing, Hybrid and Random

Failure Output

FAIL: Can not connect to service "tftp://[fd04::11]:31206/hello" from outside cluster (4/10)

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2112/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@ysksuzuki
Copy link
Member Author

Hit #22579

@ysksuzuki
Copy link
Member Author

/test-1.26-net-next

@ysksuzuki
Copy link
Member Author

@youngnick Would you be able to take a look at this PR?

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 23, 2023
@giorio94 giorio94 mentioned this pull request May 23, 2023
Closed
@borkmann borkmann merged commit fcc927f into cilium:main May 23, 2023
57 checks passed
@kaworu kaworu mentioned this pull request May 24, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@youngnick youngnick youngnick approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-blocker/1.14 This issue will prevent the release of the next version of Cilium. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ysksuzuki @qmonnet @gandro @youngnick @borkmann