.github: Fix chart push on forks #25274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checkout the SHA instead of the ref on forks, since the ref will only exist on the fork, not the upstream repository being checked out. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
added
area/CI
michi-covalent
approved these changes
May 4, 2023
|
/test |
|
test-1.26-net-next: hit #24964 |
|
/test-1.26-net-next |
brlbil
approved these changes
May 5, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently chart push fails on PRs from forks because the branch doesn't exist in the upstream cilium/cilium repository. For forks we can just use the SHA instead. We want to continue using the upstream branch as the ref if it's a non-fork PR because it gives the chart a nice name with the branch name included in it.