nodeid map: provide map via hive cell #25574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
release-note/misc
mhofstetter
force-pushed
the
pr/mhofstetter/nodemap-cell
branch
from
0675fc9
to
af740bb
Compare
|
/test |
mhofstetter
force-pushed
the
pr/mhofstetter/nodemap-cell
branch
from
af740bb
to
61312c2
Compare
|
/test -> 🟢 |
mhofstetter
added
the
kind/enhancement
mhofstetter
force-pushed
the
pr/mhofstetter/nodemap-cell
branch
from
61312c2
to
d4bb729
Compare
|
rebased to |
nathanjsweet
added
the
dont-merge/needs-rebase
mhofstetter
force-pushed
the
pr/mhofstetter/nodemap-cell
branch
from
d4bb729
to
049aa55
Compare
mhofstetter
removed
the
dont-merge/needs-rebase
|
rebased to @jrajahalme & @nathanjsweet: ready for review |
mhofstetter
force-pushed
the
pr/mhofstetter/nodemap-cell
branch
from
049aa55
to
10ef5b1
Compare
|
next rebase to |
jrajahalme
approved these changes
May 26, 2023
| }) | ||
| return nodeMap | ||
| type nodeMap struct { | ||
| bpfMap *ebpf.Map |
There was a problem hiding this comment.
nit: This could have renamed unnamed as well? Or is there value in having to call bpf Map functions explicitly?
There was a problem hiding this comment.
i kind of prefer having the inner maps functions not exposed. kind of wrapping the functionality and not extending it as it would be when having it as anonymous field.
edit: and it kind of got implemented this way for all the other BPF maps which are provided via hive cell too
|
/test |
This commit introduces a hive cell for the nodeid map. The datapath cell has been refactored to depend on the nodeid map - which introduces proper init order before accessing the map during nodeid restoration (currently only working due to the fact, that the map gets implicitly opened when iterating over its entries). Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/nodemap-cell
branch
from
10ef5b1
to
11843fb
Compare
|
rebased to @nathanjsweet : ready for review |
|
/test |
nathanjsweet
approved these changes
May 31, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a hive cell for the nodeid map.
The datapath cell has been refactored to depend on the nodeid map - which introduces explicit dependencies with a proper init order.
This way, the map is properly initialized when accessing it for nodeid restoration. Currently this is only working due to the fact, that the map gets implicitly opened when iterating over its entries.
Follow up of #25497