nodehandler: register node-id restore as hive lifecycle hook #25497
Conversation
This commit moves the node id restore from the daemon to the hive cell - where it's implemented as hive lifecycle hook. Otherwise, dependent components are trying to lookup node ids before the actual restoration - which results in newly allocated node ids. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
|
||
| params.LC.Append(hive.Hook{ | ||
| OnStart: func(hive.HookContext) error { | ||
| datapath.Node().RestoreNodeIDs() |
There was a problem hiding this comment.
note: RestoreNodeIDs will implicitly enforce opening the BPF map if it's not already opened - which is the case with this move because the OnStart lifecycle hook will be executed before the initialization of the BPF map in the daemon init.
see https://github.com/cilium/cilium/blob/main/pkg/ebpf/map.go#L177-L181
anyway - i'll come up with an additional PR which will refactor the node map to be provided as hive cell after this one got merged. This will make this dependency visible and correct the initialization order.
mhofstetter
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
|
edit: git checkout failed: /test-1.25-4.19 |
|
edit: git checkout failed: /test-runtime |
|
edit: git checkout failed: /test-1.26-net-next |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This commit moves the node id restore from the daemon to the datapath hive cell (which instantiates the
linuxNodeHandler) - where it's implemented as hive lifecycle hook.Otherwise, dependent components are trying to lookup node ids before the actual restoration - which results in unnecessary newly allocated node ids.