helm: Avoid error in IDE due to .range keyword #25766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As range is a keyword in jinja template, using the expression with usual attribute name (e.g. .Values.nodePort.range) will cause the error in IDE. This issue makes it hard for deployment helm for normal operation like checking where the flag is used. This commit is to use alternative way to get around the issue with get function. Testing was done as per below ``` $ cat temp_values.yaml nodePort: range: "30000,32767" $ helm template cilium install/kubernetes/cilium -f temp_values.yaml | grep node-port-range node-port-range: "30000,32767" enable-auto-protect-node-port-range: "true" ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
approved these changes
May 30, 2023
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As range is a keyword in jinja template, using the expression with usual attribute name (e.g. .Values.nodePort.range) will cause the error in IDE. This issue makes it hard for deployment helm for normal operation like checking where the flag is used.
This commit is to use alternative way to get around the issue with get function.
Testing was done as per below