Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Avoid error in IDE due to .range keyword #25766

Merged
merged 1 commit into from
May 31, 2023

Commits on May 30, 2023

  1. helm: Avoid error in IDE due to .range keyword

    As range is a keyword in jinja template, using the expression with usual
    attribute name (e.g. .Values.nodePort.range) will cause the error in IDE.
    This issue makes it hard for deployment helm for normal operation like
    checking where the flag is used.
    
    This commit is to use alternative way to get around the issue with get
    function.
    
    Testing was done as per below
    
    ```
    $ cat temp_values.yaml
    nodePort:
      range: "30000,32767"
    $ helm template cilium install/kubernetes/cilium -f temp_values.yaml | grep node-port-range
      node-port-range: "30000,32767"
      enable-auto-protect-node-port-range: "true"
    ```
    
    Signed-off-by: Tam Mach <tam.mach@cilium.io>
    sayboras committed May 30, 2023
    Configuration menu
    Copy the full SHA
    2409e49 View commit details
    Browse the repository at this point in the history