Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ip assignments for cilium_host from init.sh #25771

Merged
merged 3 commits into from Jun 13, 2023

Conversation

rgo3
Copy link
Contributor

@rgo3 rgo3 commented May 30, 2023

This PR continues to remove code from init.sh and ports it to Go, which for now means it will have to live in the Reinitialize().

Fixes: #25486

@rgo3 rgo3 added sig/loader Impacts the loading of BPF programs into the kernel. release-note/misc This PR makes changes that have no direct user impact. labels May 30, 2023
@rgo3 rgo3 force-pushed the initsh-hostip-assignment branch from e67091d to d2ab146 Compare May 31, 2023 12:50
@rgo3
Copy link
Contributor Author

rgo3 commented May 31, 2023

/test

@rgo3 rgo3 force-pushed the initsh-hostip-assignment branch from d2ab146 to 21f1ad7 Compare May 31, 2023 20:14
@rgo3
Copy link
Contributor Author

rgo3 commented May 31, 2023

/test

@rgo3 rgo3 force-pushed the initsh-hostip-assignment branch from 21f1ad7 to 19e1085 Compare June 1, 2023 09:09
@rgo3
Copy link
Contributor Author

rgo3 commented Jun 1, 2023

/test

@rgo3 rgo3 force-pushed the initsh-hostip-assignment branch from 19e1085 to c2105d7 Compare June 2, 2023 08:43
@rgo3
Copy link
Contributor Author

rgo3 commented Jun 2, 2023

/test

@rgo3 rgo3 marked this pull request as ready for review June 2, 2023 18:44
@rgo3 rgo3 requested a review from a team as a code owner June 2, 2023 18:44
@rgo3 rgo3 requested a review from ti-mo June 2, 2023 18:44
@rgo3 rgo3 force-pushed the initsh-hostip-assignment branch from c2105d7 to a3ed8ee Compare June 8, 2023 15:21
@rgo3
Copy link
Contributor Author

rgo3 commented Jun 8, 2023

/test

Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, looks good!

pkg/datapath/loader/netlink_test.go Outdated Show resolved Hide resolved
pkg/datapath/loader/base.go Outdated Show resolved Hide resolved
rgo3 added 3 commits June 12, 2023 14:53
Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
In preparation of the next commit this moves code in Reinitialize() so
that we collect and apply necessary sysctl settings as early as
possible.

Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
@rgo3 rgo3 force-pushed the initsh-hostip-assignment branch from a3ed8ee to ecd4fc0 Compare June 12, 2023 13:13
@rgo3
Copy link
Contributor Author

rgo3 commented Jun 12, 2023

/test

Job 'Cilium-PR-K8s-1.16-kernel-4.19' hit: #25964 (97.42% similarity)

Job 'Cilium-PR-K8s-1.26-kernel-net-next' hit: #25958 (90.52% similarity)

Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rgo3
Copy link
Contributor Author

rgo3 commented Jun 12, 2023

/test-1.16-4.19

@rgo3
Copy link
Contributor Author

rgo3 commented Jun 12, 2023

/test-1.26-net-next

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 12, 2023
@ti-mo ti-mo merged commit 163dfbd into cilium:main Jun 13, 2023
64 of 65 checks passed
@ti-mo ti-mo deleted the initsh-hostip-assignment branch June 13, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/loader Impacts the loading of BPF programs into the kernel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init.sh: assign internal node IP to HostDevice in Go
2 participants