-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ip assignments for cilium_host from init.sh #25771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgo3
added
sig/loader
Impacts the loading of BPF programs into the kernel.
release-note/misc
This PR makes changes that have no direct user impact.
labels
May 30, 2023
rgo3
force-pushed
the
initsh-hostip-assignment
branch
from
May 31, 2023 12:50
e67091d
to
d2ab146
Compare
/test |
rgo3
force-pushed
the
initsh-hostip-assignment
branch
from
May 31, 2023 20:14
d2ab146
to
21f1ad7
Compare
/test |
rgo3
force-pushed
the
initsh-hostip-assignment
branch
from
June 1, 2023 09:09
21f1ad7
to
19e1085
Compare
/test |
rgo3
force-pushed
the
initsh-hostip-assignment
branch
from
June 2, 2023 08:43
19e1085
to
c2105d7
Compare
/test |
rgo3
force-pushed
the
initsh-hostip-assignment
branch
from
June 8, 2023 15:21
c2105d7
to
a3ed8ee
Compare
/test |
ti-mo
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, looks good!
ti-mo
reviewed
Jun 12, 2023
Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
In preparation of the next commit this moves code in Reinitialize() so that we collect and apply necessary sysctl settings as early as possible. Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
Signed-off-by: Robin Gögge <r.goegge@isovalent.com>
rgo3
force-pushed
the
initsh-hostip-assignment
branch
from
June 12, 2023 13:13
a3ed8ee
to
ecd4fc0
Compare
ti-mo
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
/test-1.16-4.19 |
/test-1.26-net-next |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
sig/loader
Impacts the loading of BPF programs into the kernel.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues to remove code from init.sh and ports it to Go, which for now means it will have to live in the
Reinitialize()
.Fixes: #25486