bgpv1: Reset BGP session in UpdateNeighbor if necessary #25827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rastislavs
added
release-note/misc
rastislavs
force-pushed
the
bgp-session-restart
branch
from
a423cd4
to
30517d3
Compare
rastislavs
force-pushed
the
bgp-session-restart
branch
from
30517d3
to
45d2156
Compare
|
/test |
rastislavs
force-pushed
the
bgp-session-restart
branch
from
45d2156
to
4f91a9e
Compare
|
/test |
youngnick
approved these changes
Jun 5, 2023
As Cilium's user-facing API based on CRDs is intent-based, this PR ensures that updated BGP peer configuration is always applied also on existing BGP sessions immediately, even if it requires a session reset. If the underlying BGP implementation (GoBGP at the moment) does not reset the session for particular configuration items automatically, we enforce the session reset explicitly. Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
|
|
rastislavs
force-pushed
the
bgp-session-restart
branch
from
4f91a9e
to
2db93c1
Compare
|
/test |
|
All checks passing and reviews are in. Ready to merge. |
rastislavs
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Cilium's user-facing API based on CRDs is intent-based, this PR ensures that updated BGP peer configuration is always applied also on existing BGP sessions immediately, even if it requires a session reset. If the underlying BGP implementation (GoBGP at the moment) does not reset the session for particular configuration items automatically, we enforce the session reset explicitly.
For example, changing
HoldTimefor a peer will cause the followingNOTIFICATIONmessage:Followed by a session re-establishment and the new timer interval exchanged in the
OPENmessage: