-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: Document BGP timers & neighbor update behavior #25906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Jun 5, 2023
rastislavs
added
release-note/misc
This PR makes changes that have no direct user impact.
area/bgp
labels
Jun 5, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Jun 5, 2023
rastislavs
force-pushed
the
bgp-timers-docs
branch
4 times, most recently
from
June 7, 2023 13:47
945b4e7
to
b9be6f1
Compare
qmonnet
reviewed
Jun 7, 2023
rastislavs
force-pushed
the
bgp-timers-docs
branch
from
June 7, 2023 15:21
b9be6f1
to
8da9d62
Compare
Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
rastislavs
force-pushed
the
bgp-timers-docs
branch
from
June 7, 2023 15:31
8da9d62
to
600c61f
Compare
harsimran-pabla
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, lgtm.
qmonnet
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Doc change only, documentation workflow and Netlify preview passed. This is ready to merge. |
qmonnet
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/bgp
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for the BGP timer parameters (added in #25408) & BGP neighbor update behavior (updated in #25827).