ci: Wait for hubble-relay to be ready before port-forward #25839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
learnitall
force-pushed
the
pr/learnitall/flake-issue-25560
branch
from
1632ac4
to
767e8ad
Compare
This commit adds calls to `cilium status --wait` between places where hubble is enabled and hubble-relay is port forwarded. Flakes in CI were occurring due to a race conditition, where an attempt to forward the hubble-relay port was occurring before the hubble-relay pod was ready. Related: cilium/cilium-cli#986 Fixes: cilium#25560 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
learnitall
force-pushed
the
pr/learnitall/flake-issue-25560
branch
from
767e8ad
to
5ffba4b
Compare
Closed
aspsk
approved these changes
Jun 8, 2023
|
I've tested that this works in a different PR, as I couldn't push to this one (see #26030). So this one is ready to merge. |
aspsk
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds calls to
cilium status --waitbetween places where hubble is enabled and hubble-relay is port forwarded. Flakes in CI were occurring due to a race conditition, where an attempt to forward the hubble-relay port was occurring before the hubble-relay pod was ready.Related: cilium/cilium-cli#986
Fixes: #25560