k8s: Update comment about rule preprocessing #25864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
qmonnet
reviewed
Jun 2, 2023
There is a difference between headless services, and services without a selector (sometimes referred to as external services in cilium). Those services without a selector can be headless or have a ClusterIP; but the important thing, is that this function care about services without a selector, independent on the ClusterIP. Signed-off-by: Odin Ugedal <ougedal@palantir.com> Signed-off-by: Odin Ugedal <odin@uged.al>
.ToService rules only apply to services without selectors. The term headless service is a service without a ClusterIP; and those are distinct terms. Signed-off-by: Odin Ugedal <ougedal@palantir.com>
odinuge
force-pushed
the
service-endpoints
branch
from
11ee588
to
44d1008
Compare
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
@joestringer could you take a quick look to see if this is correct from the policy perspective? Do we potentially have more cases where this might be wrong? |
joestringer
approved these changes
Jun 5, 2023
|
Are we good to merge this now? Want to get this merged to avoid conflicts with other pending work |
|
Ping @nathanjsweet |
nathanjsweet
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a difference between headless services, and services without a selector (sometimes referred to as external services in cilium). Those services without a selector can be headless or have a ClusterIP; but the important thing, is that this function care about services without a selector, independent on the ClusterIP. See commit messages for more context.