Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: Update comment about rule preprocessing #25864

Merged
merged 2 commits into from
Jun 9, 2023
Merged

k8s: Update comment about rule preprocessing #25864

merged 2 commits into from
Jun 9, 2023

Commits on Jun 2, 2023

  1. k8s: Update comment about rule preprocessing 

    There is a difference between headless services, and services without a
selector (sometimes referred to as external services in cilium). Those
services without a selector can be headless or have a ClusterIP; but the
important thing, is that this function care about services without a
selector, independent on the ClusterIP.

Signed-off-by: Odin Ugedal <ougedal@palantir.com>
Signed-off-by: Odin Ugedal <odin@uged.al>
    @odinuge
    odinuge committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    fc6376f View commit details
    Browse the repository at this point in the history

  2. docs; update toService docs about headless services 

    .ToService rules only apply to services without selectors. The term
headless service is a service without a ClusterIP; and those are
distinct terms.

Signed-off-by: Odin Ugedal <ougedal@palantir.com>
    @odinuge
    odinuge committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    44d1008 View commit details
    Browse the repository at this point in the history