build: Avoid cross compilation issue on Windows #25904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
michi-covalent
force-pushed
the
tam/cross-compile
branch
from
35ce8d5
to
68ef9ec
Compare
|
/test |
joamaki
requested changes
Jun 6, 2023
Happens in cilium-cli PR when trying to import the latest cilium/cilium main hash. This commit is to perform the following: - Remove unix.SIGINT as it's same as os.Interrupt - Replace unix.SIGTERM by syscall.SIGTERM for cross compilation ``` Error: vendor/github.com/cilium/cilium/pkg/hive/hive.go:202:44: undefined: unix.SIGINT Error: vendor/github.com/cilium/cilium/pkg/hive/hive.go:202:57: undefined: unix.SIGTERM Error: Process completed with exit code 1. ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/cross-compile
branch
from
68ef9ec
to
2ee4320
Compare
|
/test |
rgo3
approved these changes
Jun 6, 2023
|
/test-runtime |
joamaki
approved these changes
Jun 6, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happens in cilium-cli PR when trying to import the latest cilium/cilium main hash.