Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Avoid cross compilation issue on Windows #25904

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Commits on Jun 6, 2023

  1. build: Avoid cross compilation issue on Windows

    Happens in cilium-cli PR when trying to import the latest cilium/cilium
    main hash. This commit is to perform the following:
    
    - Remove unix.SIGINT as it's same as os.Interrupt
    - Replace unix.SIGTERM by syscall.SIGTERM for cross compilation
    
    ```
    Error: vendor/github.com/cilium/cilium/pkg/hive/hive.go:202:44: undefined: unix.SIGINT
    Error: vendor/github.com/cilium/cilium/pkg/hive/hive.go:202:57: undefined: unix.SIGTERM
    Error: Process completed with exit code 1.
    ```
    
    Signed-off-by: Tam Mach <tam.mach@cilium.io>
    sayboras committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    2ee4320 View commit details
    Browse the repository at this point in the history