Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Document BGP timers & neighbor update behavior #25906

Merged
merged 1 commit into from Jun 7, 2023

Conversation

rastislavs
Copy link
Contributor

Adds documentation for the BGP timer parameters (added in #25408) & BGP neighbor update behavior (updated in #25827).

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 5, 2023
@rastislavs rastislavs added release-note/misc This PR makes changes that have no direct user impact. area/bgp labels Jun 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 5, 2023
@rastislavs rastislavs force-pushed the bgp-timers-docs branch 4 times, most recently from 945b4e7 to b9be6f1 Compare June 7, 2023 13:47
@rastislavs rastislavs marked this pull request as ready for review June 7, 2023 14:11
@rastislavs rastislavs requested review from a team as code owners June 7, 2023 14:11
Signed-off-by: Rastislav Szabo <rastislav.szabo@isovalent.com>
Copy link
Contributor

@harsimran-pabla harsimran-pabla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm.

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@qmonnet
Copy link
Member

qmonnet commented Jun 7, 2023

Doc change only, documentation workflow and Netlify preview passed. This is ready to merge.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2023
@dylandreimerink dylandreimerink merged commit f8d93a4 into cilium:main Jun 7, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants