bpf unit tests: Run tests on changes to pks/bpf/** #25911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go program used to run the BPF unit tests has a few dependencies on other Cilium packages, namely: - pkg/bpf - pkg/byteorder - pkg/datapath/link - pkg/monitor In the past, we nearly merged a change that would break the unit tests, because the CI skipped the unit tests job for the related PR. The reason was that the changes didn't touch BPF files (or the runner's sources), but the way we collect programs and perform relocations from an ELF file in pkg/bpf/collection.go. To avoid repeating this in the future, let's mark pkg/bpf/** updates as a trigger for the unit tests. The other dependency packages could be added too, but they seem less critical (and less likely to break the tests), so we leave them aside for now. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
added
area/CI
aanm
approved these changes
Jun 6, 2023
nebril
approved these changes
Jun 6, 2023
|
Travis hit a documented flake. BPF checks workflow is still valid (The workflow didn't crash. The test itself was skipped because none of the relevant files were touched). No need for the full CI suite, I'm marking as ready-to-merge. |
qmonnet
added
the
ready-to-merge
|
Agreed, travis is hitting a flake in the new BGP tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go program used to run the BPF unit tests has a few dependencies on other Cilium packages, namely:
In the past, we nearly merged a change that would break the unit tests, because the CI skipped the unit tests job for the related PR. The reason was that the changes didn't touch BPF files (or the runner's sources), but the way we collect programs and perform relocations from an ELF file in pkg/bpf/collection.go.
To avoid repeating this in the future, let's mark
pkg/bpf/**updates as a trigger for the unit tests. The other dependency packages could be added too, but they seem less critical (and less likely to break the tests), so we leave them aside for now.Reference: #25837 (review)