Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf unit tests: Run tests on changes to pks/bpf/** #25911

Merged
merged 1 commit into from
Jun 6, 2023
Merged

bpf unit tests: Run tests on changes to pks/bpf/** #25911

merged 1 commit into from
Jun 6, 2023

Commits on Jun 5, 2023

  1. bpf unit tests: Run tests on changes to pks/bpf/** 

    The Go program used to run the BPF unit tests has a few dependencies on
other Cilium packages, namely:

  - pkg/bpf
  - pkg/byteorder
  - pkg/datapath/link
  - pkg/monitor

In the past, we nearly merged a change that would break the unit tests,
because the CI skipped the unit tests job for the related PR. The reason
was that the changes didn't touch BPF files (or the runner's sources),
but the way we collect programs and perform relocations from an ELF file
in pkg/bpf/collection.go.

To avoid repeating this in the future, let's mark pkg/bpf/** updates as
a trigger for the unit tests. The other dependency packages could be
added too, but they seem less critical (and less likely to break the
tests), so we leave them aside for now.

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
    @qmonnet
    qmonnet committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    eecef39 View commit details
    Browse the repository at this point in the history