Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI image build cache #26020

Merged
merged 1 commit into from Jun 9, 2023
Merged

Fix CI image build cache #26020

merged 1 commit into from Jun 9, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Jun 8, 2023

Read per commit basis

@aanm aanm added area/CI Continuous Integration testing issue or flake area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 8, 2023
@aanm aanm requested a review from giorio94 June 8, 2023 09:21
@aanm aanm requested review from a team as code owners June 8, 2023 09:21
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.4 Jun 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.11.18 Jun 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.11 Jun 8, 2023
viktor-kurchenko
viktor-kurchenko approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aanm
.github: checkout source code to perform cache clean up
0350880 
When performing a golang cache cleanup we need to fetch the source code
so that we can retrieve the right hashfile from '**/go.sum' otherwise it
will always be empty.

Signed-off-by: André Martins <andre@cilium.io>
@qmonnet qmonnet added this to Needs backport from main in 1.13.5 Jun 9, 2023
@qmonnet qmonnet removed this from Needs backport from main in 1.13.4 Jun 9, 2023
@aanm aanm merged commit 89bb0a3 into cilium:main Jun 9, 2023
49 checks passed
@aanm aanm deleted the pr/fix-golang-cache branch June 9, 2023 14:40
@michi-covalent michi-covalent added this to Needs backport from main in 1.12.12 Jun 12, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.12.11 Jun 12, 2023
@michi-covalent michi-covalent mentioned this pull request Jun 13, 2023
Closed
7 tasks
@michi-covalent michi-covalent added this to Needs backport from main in 1.11.19 Jun 14, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.11.18 Jun 14, 2023
@nbusseneau
Copy link
Member

nbusseneau commented Jun 22, 2023 •
edited

Image cache did not exist in 1.11 (or it's not a workflow we have for stable branches), removing backport label.

@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
Merged
7 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.11 in 1.11.18 Jun 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.11 in 1.11.18 Jun 22, 2023
@nbusseneau nbusseneau removed this from Needs backport from main in 1.11.19 Jun 22, 2023
@nbusseneau
Copy link
Member

Same for 1.12.

@nbusseneau nbusseneau removed this from Needs backport from main in 1.12.12 Jun 22, 2023
@nbusseneau
Copy link
Member

Same for 1.13.

@nbusseneau nbusseneau removed the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Jun 22, 2023
@nbusseneau nbusseneau removed this from Needs backport from main in 1.13.5 Jun 22, 2023
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
Merged
19 tasks
@nbusseneau nbusseneau added the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Jun 22, 2023
@tklauser tklauser added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 29, 2023
@nbusseneau nbusseneau removed the backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorio94 giorio94 giorio94 approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aanm @nbusseneau @giorio94 @viktor-kurchenko @tklauser