v1.13 backports 2023-06-13 #26199
Closed
v1.13 backports 2023-06-13 #26199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 3eaca5d ] Commit 8531c5a ("bpf,datapath: read jiffies from /proc/schedstat") switched package ctmap over to using /proc/schedstat for getting kernel jiffies. During the conversion, a shift by a magic 'scaler' value was missed, leading to strange output in `cilium bpf ct list global -d` (.. (remaining: -4391264792 sec(s)) ..) and the CT GC never collecting any flows, since the current jiffies were always perceived to be orders of magnitude larger than the flow expiry time. This patch wraps probes.Jiffies() in a documented scaledJiffies() helper and declares the BPF_MONO_SCALER macro as a Go constant. Signed-off-by: Timo Beckers <timo@isovalent.com> Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added
kind/backports
|
Job 'Cilium-PR-K8s-1.24-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.24-kernel-4.19/39/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/778/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: