gha: fix conformance-ginkgo base branch retrieval #26085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
giorio94
added
area/CI
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
giorio94
force-pushed
the
pr/giorio94/conformance-gingo
branch
from
e6f367a
to
c1b6017
Compare
Let's make sure that we use the correct URL to retrieve the PR information also when the workflow is triggered by a pull_request event. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Retrieving the base branch from github.base_branch does not work when the action is triggered by a comment, because that field is not populated. Let's retrieve it from the json information about the PR. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/conformance-gingo
branch
2 times, most recently
from
c6d5c01
to
d032acd
Compare
qmonnet
approved these changes
Jun 9, 2023
|
The matrix got generated correctly: https://github.com/cilium/cilium/actions/runs/5224161919/jobs/9432015821?pr=26085. |
aanm
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieving the base branch from
github.base_branchdoes not work when the action is triggered by a comment, because that field is not populated. Let's retrieve it from the json information about the PR. Additionally, let's make sure that we use the correct URL to retrieve the PR information also when the workflow is triggered by a pull_request event.Link to running workflow: https://github.com/cilium/cilium/actions/runs/5224161919/jobs/9432015821?pr=26085