Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gha: fix conformance-ginkgo base branch retrieval #26085

Merged
merged 2 commits into from
Jun 9, 2023
Merged

gha: fix conformance-ginkgo base branch retrieval #26085

merged 2 commits into from
Jun 9, 2023

Commits on Jun 9, 2023

  1. gha: fix conformance-ginkgo target pull request URL 

    Let's make sure that we use the correct URL to retrieve the PR
information also when the workflow is triggered by a pull_request event.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
    @giorio94
    giorio94 committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    7c7e9c0 View commit details
    Browse the repository at this point in the history

  2. gha: fix conformance-ginkgo base branch retrieval 

    Retrieving the base branch from github.base_branch does not work when
the action is triggered by a comment, because that field is not
populated. Let's retrieve it from the json information about the PR.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
    @giorio94
    giorio94 committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d032acd View commit details
    Browse the repository at this point in the history