BGP CP: Adds Intro to Docs #26195
Merged
BGP CP: Adds Intro to Docs #26195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
cc: @YutaroHayakawa since you commented on the related issue. |
harsimran-pabla
requested changes
Jun 13, 2023
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
zacharysarah
requested changes
Jun 14, 2023
There was a problem hiding this comment.
@danehans Good start. Words like "this" make it difficult to understand what exactly you're referring to, and what specifically is taking action. Please revise then re-request review.
harsimran-pabla
approved these changes
Jun 15, 2023
YutaroHayakawa
approved these changes
Jun 16, 2023
zacharysarah
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
@danehans Thank you, great improvement! 🏆 Only some nits to fix--approving to unblock, with the understanding that changes are required prior to merge.
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
|
Commit cbdc1de resolves @zacharysarah's review comments. |
|
Reviews are in and document preview CI is passing. Since this PR only changes documents, I'll skip running full CIs. |
YutaroHayakawa
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates BGP CP docs with an introduction section that provides an explanation of the feature.
Relates to: #26146