-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BGP CP: Adds Intro to Docs #26195
BGP CP: Adds Intro to Docs #26195
Conversation
cc: @YutaroHayakawa since you commented on the related issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this section, minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danehans Good start. Words like "this" make it difficult to understand what exactly you're referring to, and what specifically is taking action. Please revise then re-request review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danehans Thank you, great improvement! 🏆 Only some nits to fix--approving to unblock, with the understanding that changes are required prior to merge.
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
Commit cbdc1de resolves @zacharysarah's review comments. |
Reviews are in and document preview CI is passing. Since this PR only changes documents, I'll skip running full CIs. |
Updates BGP CP docs with an introduction section that provides an explanation of the feature.
Relates to: #26146