clustermesh: unbreak test #26294
Merged
clustermesh: unbreak test #26294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error: pkg/clustermesh/remote_cluster_test.go:155:54: too many arguments in call to newGlobalServiceCache
have (string, string)
want ("github.com/cilium/cilium/pkg/metrics/metric".Gauge)
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Let's ensure that all keys are deleted when the clustermesh tests terminate, to prevent affecting the subsequent ones. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
It seems that the new kvstoremesh tests are badly interacting with the other clustermesh ones (they use a shared etcd instance), causing frequent flakes. Let's disable them for the moment while figuring out how to make them more resilient. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
kind/bug/CI
YutaroHayakawa
approved these changes
Jun 16, 2023
|
Integration tests passed. Marking as ready to merge to unblock main |
giorio94
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a merge race, one of the clustermesh tests is failing to compile:
Additionally, it seems that the newly introduced tests are badly interacting with each other (they use the same shared etcd instance), causing frequent flakes. Let's disable them for the moment to unblock main, and in the meanwhile I'll try to figure out how to make them more resilient.
Supersedes: #26291 (thanks @julianwiedmann)