Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clustermesh: unbreak test #26294

Merged
merged 3 commits into from
Jun 16, 2023
Merged

clustermesh: unbreak test #26294

merged 3 commits into from
Jun 16, 2023

Commits on Jun 16, 2023

  1. clustermesh: unbreak test 

    Error: pkg/clustermesh/remote_cluster_test.go:155:54: too many arguments in call to newGlobalServiceCache
	have (string, string)
	want ("github.com/cilium/cilium/pkg/metrics/metric".Gauge)

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
    @julianwiedmann
    julianwiedmann committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    20feeb2 View commit details
    Browse the repository at this point in the history

  2. clustermesh: delete the entire kvstore key space on test end 

    Let's ensure that all keys are deleted when the clustermesh tests
terminate, to prevent affecting the subsequent ones.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
    @giorio94
    giorio94 committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    c9ce203 View commit details
    Browse the repository at this point in the history

  3. kvstoremesh: temporarily skip the tests as too flaky 

    It seems that the new kvstoremesh tests are badly interacting with the
other clustermesh ones (they use a shared etcd instance), causing
frequent flakes. Let's disable them for the moment while figuring out
how to make them more resilient.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
    @giorio94
    giorio94 committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    d5f8220 View commit details
    Browse the repository at this point in the history