k8s,metrics: Remove double k8s event accounting #26349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
kind/bug
|
Converting to draft, something did not quite go right, for some reasons this commit contains unrelated changes |
dylandreimerink
force-pushed
the
feature/remove-double-metric-accounting
branch
2 times, most recently
from
3605fed
to
aa5fd4f
Compare
|
Resolved 😅 🙏 |
|
Go lint says there is an unused function: |
christarazi
added
sig/k8s
christarazi
approved these changes
Jun 21, 2023
dylandreimerink
force-pushed
the
feature/remove-double-metric-accounting
branch
from
aa5fd4f
to
620f8bb
Compare
aditighag
approved these changes
Jun 27, 2023
|
/test |
I introduced the bug myself in #26269, Jussi cought it like 2 seconds after the thing was merged, so I just made the fix without going through the process of making an issue |
Resources increment the k8s event metrics themselves now. This causes duplicate metric accounting for k8s watchers that have been implemented in terms of resources and also do metrics tracking. This commit removes the metrics tracking done by k8s watchers that are implemented with resources. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/remove-double-metric-accounting
branch
from
620f8bb
to
04808f4
Compare
|
/test |
dylandreimerink
added
the
needs-backport/1.14
joamaki
added
backport-pending/1.14
jibi
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources increment the k8s event metrics themselves now. This causes duplicate metric accounting for k8s watchers that have been implemented in terms of resources and also do metrics tracking.
This PR removes the metrics tracking done by k8s watchers that are implemented with resources.