Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s.Resource metrics #26269

Merged

Conversation

dylandreimerink
Copy link
Member

@dylandreimerink dylandreimerink commented Jun 15, 2023

This PR makes the pkg/k8s/resources emit the same metrics as their
k8s watcher counterparts. The only difference is that due to the
asynchronous nature of resource consumers, we are not able to track when
all consumers have processed the same event, thus we increment the
processed event metric for every consumer.

Added metrics for pkg/k8s/resource

@dylandreimerink dylandreimerink added the dont-merge/preview-only Only for preview or testing, don't merge it. label Jun 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 15, 2023
@dylandreimerink dylandreimerink changed the title WIP k8s.Resource metrics Jun 15, 2023
This commit makes the pkg/k8s/resources emit the same metrics as their
k8s watcher counterparts. The only difference is that due to the
asynchronous nature of resource consumers, we are not able to track when
all consumers have processed the same event, thus we increment the
processed event metric for every consumer.

Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
@dylandreimerink dylandreimerink added the release-note/misc This PR makes changes that have no direct user impact. label Jun 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 16, 2023
@dylandreimerink dylandreimerink added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/preview-only Only for preview or testing, don't merge it. labels Jun 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 16, 2023
@dylandreimerink dylandreimerink marked this pull request as ready for review June 16, 2023 11:34
@dylandreimerink dylandreimerink requested review from a team as code owners June 16, 2023 11:34
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for BGP

@dylandreimerink
Copy link
Member Author

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants