test: Fix the attempted fix for the hostfw flake #26362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 0cfce97 ("test/k8s: add host firewall workaround for svc host policy test.") ported the fix from 439a0a0 ("test: Fix ACK and FIN+ACK policy drops in hostfw tests") to a new set of host firewall tests. It is however not enough to call the same function. We also need to ensure that the same policy as in the tests themselves is loaded during the preparation. This commit makes that small change. Fixes: 0cfce97 ("test/k8s: add host firewall workaround for svc host policy test.") Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
pchaigno
added
area/CI
|
/test |
|
/ci-ginkgo hit flake #26012 |
|
Not sure what you mean. It is passing now, no? |
|
ah, wrong PR, it was meant to be in #26371 🤦 |
christarazi
approved these changes
Jun 20, 2023
pchaigno
added
the
ready-to-merge
marseel
added a commit
to marseel/cilium
that referenced
this pull request
Jun 26, 2023
Fix bug introduced in cilium#26362 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
ldelossa
pushed a commit
that referenced
this pull request
Jun 29, 2023
Fix bug introduced in #26362 Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0cfce97 ("test/k8s: add host firewall workaround for svc host policy test.") ported the fix from 439a0a0 ("test: Fix ACK and FIN+ACK policy drops in hostfw tests") to a new set of host firewall tests.
It is however not enough to call the same function. We also need to ensure that the same policy as in the tests themselves is loaded during the preparation.
This pull request makes that small change.
Related: #25461.