Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test/k8s: quarantine High-scale IPcache test" #26371

Closed
wants to merge 2 commits into from
Closed

Revert "test/k8s: quarantine High-scale IPcache test" #26371

wants to merge 2 commits into from

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Jun 20, 2023

This reverts commit 87d41e6.

Fixes: #25605

@marseel marseel requested review from a team as code owners June 20, 2023 10:15
@marseel marseel requested review from aspsk and nebril June 20, 2023 10:15
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 20, 2023
@marseel
Copy link
Contributor Author

marseel commented Jun 20, 2023

/test

@marseel marseel mentioned this pull request Jun 20, 2023
Merged
@marseel
Copy link
Contributor Author

marseel commented Jun 20, 2023

Now test failed with:

daemon creation failed: unable to initialize kube-proxy replacement options: The high-scale IPcache mode requires Node Port mode \\\"dsr\\\" with geneve dispatch

and from logs:

--bpf-lb-mode='snat'"

which comes from the fact, that test runs with kube-proxy-replacement=strict, which enables node-port

@nebril nebril marked this pull request as draft June 21, 2023 11:19
@marseel marseel force-pushed the revert_quarantine_for_highscale_ipsec branch from d8aa079 to 8028760 Compare June 21, 2023 14:16
@marseel marseel changed the title [WIP] Revert "test/k8s: quarantine High-scale IPcache test" Revert "test/k8s: quarantine High-scale IPcache test" Jun 21, 2023
@marseel
Copy link
Contributor Author

marseel commented Jun 21, 2023

/test

@marseel
Revert "test/k8s: quarantine High-scale IPcache test"
d6f5b18 
This reverts commit 87d41e6.

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel
Remove vxlan high-scale ipcache test.
96730df 
Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@marseel marseel force-pushed the revert_quarantine_for_highscale_ipsec branch from 8028760 to 96730df Compare June 28, 2023 11:34
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jul 29, 2023
@github-actions
Copy link

This pull request has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk Awaiting requested review from aspsk aspsk is a code owner automatically assigned from cilium/sig-datapath

@nebril nebril Awaiting requested review from nebril nebril is a code owner automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Suite-k8s-1.26.K8sDatapathConfig High-scale IPcache Test ingress policy enforcement
1 participant
@marseel