New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Workflow: Add all GKE supported k8s version #26364
Conversation
f07abc5
to
0990ab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM provided we address the dependency on #26356, some whitespace nits below (non-blocking).
The current conformance tests run against one version of k8s either a specific version or the default version that is provided GCP. This commit adds all the supported k8s version by GCP in a matrix strategy. Signed-off-by: Birol Bilgin <birol@cilium.io>
0990ab0
to
9be7a46
Compare
--- | ||
k8s: | ||
- version: "1.22" | ||
zone: northamerica-northeast1-c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT we are now spreading to many different zones - are we now more likely to fail the test if any zone has an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and no. These tests only run when it is triggered with a schedule event. So for normal daily runs, it will prefer the same zone as always. With schedule, it will run many clusters at the same time so it would be much more problematic to run them all in the same zone.
It may be cases where the zone affects the result of a test but also helps to verify if it is related to Cilium or k8s version by isolating the test.
The current conformance tests run against one version of k8s either a specific version or the default version that is provided by GCP.
This commit adds all the supported k8s versions by GCP in a matrix strategy.
Normal test runs:
✅ conformance-externalworkloads-v1.11.yaml
✅ conformance-externalworkloads-v1.12.yaml
✅ conformance-externalworkloads-v1.13.yaml
✅ conformance-externalworkloads.yaml
✅ conformance-gke-v1.11.yaml
✅ conformance-gke-v1.12.yaml
✅ conformance-gke-v1.13.yaml
✅ conformance-gke.yaml
Simulated scheduled runs:
✅ conformance-externalworkloads-v1.11.yaml
✅ conformance-externalworkloads-v1.12.yaml
✅ conformance-externalworkloads-v1.13.yaml
✅ conformance-externalworkloads.yaml
✅ conformance-gke-v1.11.yaml
✅ conformance-gke-v1.12.yaml
✅ conformance-gke-v1.13.yaml
✅ conformance-gke.yaml
Depends on: #26356