Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Workflow: Add all GKE supported k8s version #26364

Merged
merged 1 commit into from Jun 21, 2023

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Jun 19, 2023

The current conformance tests run against one version of k8s either a specific version or the default version that is provided by GCP.

This commit adds all the supported k8s versions by GCP in a matrix strategy.

Normal test runs:
conformance-externalworkloads-v1.11.yaml
conformance-externalworkloads-v1.12.yaml
conformance-externalworkloads-v1.13.yaml
conformance-externalworkloads.yaml
conformance-gke-v1.11.yaml
conformance-gke-v1.12.yaml
conformance-gke-v1.13.yaml
conformance-gke.yaml

Simulated scheduled runs:
conformance-externalworkloads-v1.11.yaml
conformance-externalworkloads-v1.12.yaml
conformance-externalworkloads-v1.13.yaml
conformance-externalworkloads.yaml
conformance-gke-v1.11.yaml
conformance-gke-v1.12.yaml
conformance-gke-v1.13.yaml
conformance-gke.yaml

Depends on: #26356

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 19, 2023
@brlbil brlbil added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Jun 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 19, 2023
@brlbil brlbil force-pushed the pr/brlbil/ci-gke-k8s-versions branch 5 times, most recently from f07abc5 to 0990ab0 Compare June 20, 2023 12:14
@brlbil brlbil marked this pull request as ready for review June 20, 2023 12:14
@brlbil brlbil requested review from a team as code owners June 20, 2023 12:14
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided we address the dependency on #26356, some whitespace nits below (non-blocking).

.github/actions/gke/k8s-versions.yaml Outdated Show resolved Hide resolved
The current conformance tests run against one version of k8s either
a specific version or the default version that is provided GCP.

This commit adds all the supported k8s version by GCP
in a matrix strategy.

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-gke-k8s-versions branch from 0990ab0 to 9be7a46 Compare June 21, 2023 06:53
---
k8s:
- version: "1.22"
zone: northamerica-northeast1-c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT we are now spreading to many different zones - are we now more likely to fail the test if any zone has an issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and no. These tests only run when it is triggered with a schedule event. So for normal daily runs, it will prefer the same zone as always. With schedule, it will run many clusters at the same time so it would be much more problematic to run them all in the same zone.
It may be cases where the zone affects the result of a test but also helps to verify if it is related to Cilium or k8s version by isolating the test.

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 21, 2023
@ti-mo ti-mo merged commit 823831f into main Jun 21, 2023
47 of 52 checks passed
@ti-mo ti-mo deleted the pr/brlbil/ci-gke-k8s-versions branch June 21, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants