-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Workflow: Add all GKE supported k8s version #26364
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| k8s: list(include('k8sVersionItem')) | ||
| --- | ||
| k8sVersionItem: | ||
| version: str() | ||
| zone: str() | ||
| default: bool(required=False) | ||
| vmIndex: int() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # List of k8s version for GKE tests | ||
| --- | ||
| k8s: | ||
| - version: "1.22" | ||
| zone: northamerica-northeast1-c | ||
| vmIndex: 1 | ||
| - version: "1.23" | ||
| zone: europe-west6-b | ||
| vmIndex: 2 | ||
| - version: "1.24" | ||
| zone: us-west2-a | ||
| vmIndex: 3 | ||
| default: true | ||
| - version: "1.25" | ||
| zone: asia-northeast1-c | ||
| vmIndex: 4 | ||
| - version: "1.26" | ||
| zone: europe-north1-b | ||
| vmIndex: 5 | ||
| - version: "1.27" | ||
| zone: us-east5-a | ||
| vmIndex: 6 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # List of test cases for conformance-gke with helm installation options | ||
| --- | ||
| config: | ||
| - type: "no-tunnel" | ||
| index: 1 | ||
| cilium-install-opts: "" | ||
| - type: "tunnel" | ||
| index: 2 | ||
| cilium-install-opts: "--datapath-mode=tunnel" | ||
| - type: "ipsec" | ||
| index: 3 | ||
| cilium-install-opts: "--encryption=ipsec" | ||
| - type: "tunnel-ipsec" | ||
| index: 4 | ||
| cilium-install-opts: "--encryption=ipsec --datapath-mode=tunnel" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # List of test cases for conformance-gke with helm installation options | ||
| --- | ||
| config: | ||
| - type: "no-tunnel" | ||
| index: 1 | ||
| cilium-install-opts: "" | ||
| - type: "tunnel" | ||
| index: 2 | ||
| cilium-install-opts: "--datapath-mode=tunnel" | ||
| - type: "ipsec" | ||
| index: 3 | ||
| cilium-install-opts: "--helm-set=encryption.enabled=true --helm-set=encryption.type=ipsec" | ||
| - type: "tunnel-ipsec" | ||
| index: 4 | ||
| cilium-install-opts: "--helm-set=encryption.enabled=true --helm-set=encryption.type=ipsec --datapath-mode=tunnel" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| config: list(include('testConfigItem')) | ||
| --- | ||
| testConfigItem: | ||
| type: str() | ||
| index: int() | ||
| cilium-install-opts: str() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT we are now spreading to many different zones - are we now more likely to fail the test if any zone has an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and no. These tests only run when it is triggered with a schedule event. So for normal daily runs, it will prefer the same zone as always. With schedule, it will run many clusters at the same time so it would be much more problematic to run them all in the same zone.
It may be cases where the zone affects the result of a test but also helps to verify if it is related to Cilium or k8s version by isolating the test.