Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set CILIUM_CLI_MODE env variable at the top level #26387

Merged
merged 1 commit into from Jun 21, 2023
Merged

Set CILIUM_CLI_MODE env variable at the top level #26387

merged 1 commit into from Jun 21, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Jun 21, 2023 •
edited

Set CILIUM_CLI_MODE environment variable to helm at the top level so that all the cilium commands use the Helm mode consistently. This pull request updates all the workflows that use the pull_request trigger.

@michi-covalent michi-covalent added the release-note/ci This PR makes changes to the CI. label Jun 21, 2023
@michi-covalent
Copy link
Contributor Author

/test

sayboras
sayboras approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ingress and gateway workflow, I put flag in command level as during that time not all commands are working fine with helm mode (e.g. some says invalid flag, etc). It's good to set it globally now 👍. LGTM ✅.

@michi-covalent michi-covalent marked this pull request as ready for review June 21, 2023 04:29
@michi-covalent michi-covalent requested review from a team as code owners June 21, 2023 04:29
@michi-covalent michi-covalent added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 21, 2023
@michi-covalent
Set CILIUM_CLI_MODE env variable at the top level
d250d2b 
Set CILIUM_CLI_MODE environment variable to helm at the top level so
that all the cilium commands use the Helm mode consistently.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jun 21, 2023
@michi-covalent
Copy link
Contributor Author

/test

@christarazi christarazi added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow labels Jun 21, 2023
christarazi
christarazi approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@michi-covalent michi-covalent merged commit 93bcd42 into main Jun 21, 2023
63 checks passed
@michi-covalent michi-covalent deleted the pr/michi/helm-mode branch June 21, 2023 20:06
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@christarazi christarazi christarazi approved these changes

@sayboras sayboras sayboras approved these changes

@nbusseneau nbusseneau Awaiting requested review from nbusseneau nbusseneau is a code owner automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michi-covalent @joestringer @christarazi @sayboras