-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CILIUM_CLI_MODE env variable at the top level #26387
Conversation
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ingress and gateway workflow, I put flag in command level as during that time not all commands are working fine with helm mode (e.g. some says invalid flag, etc). It's good to set it globally now 👍. LGTM ✅.
Set CILIUM_CLI_MODE environment variable to helm at the top level so that all the cilium commands use the Helm mode consistently. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
206471d
to
d250d2b
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢 🚢
Set CILIUM_CLI_MODE environment variable to helm at the top level so that all the cilium commands use the Helm mode consistently. This pull request updates all the workflows that use the
pull_request
trigger.