Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Workflows: Fix sysdump file creation #26402

Merged
merged 1 commit into from Jun 22, 2023
Merged

CI Workflows: Fix sysdump file creation #26402

merged 1 commit into from Jun 22, 2023

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Jun 21, 2023 •
edited

Currently, conformance tests that run in matrix strategy do not create sysdump files with a unique name.
Only one report is uploaded in GitHub artifacts. This changes sysdump files names uniq per matrix run.

Test run, it generates sysdump per matrix run.
https://github.com/cilium/cilium/actions/runs/5336461842?pr=26402

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 21, 2023
@brlbil brlbil force-pushed the pr/brlbil/ci-fix-sysdump-names branch 2 times, most recently from 0c949ff to f4d987d Compare June 21, 2023 16:14
@marseel marseel mentioned this pull request Jun 21, 2023
Closed
@brlbil brlbil force-pushed the pr/brlbil/ci-fix-sysdump-names branch from f4d987d to b999061 Compare June 21, 2023 16:46
@brlbil
ci/workflows: fix sysdump file creation
9431cbf 
Currently conformance tests that runs in matrix strategy do not create
sysdump files with a uniq name. Only one report is uploaded in github
artifacts. This changes sysdump files names uniq per matrix run.

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-fix-sysdump-names branch from b999061 to 9431cbf Compare June 21, 2023 17:43
@brlbil brlbil marked this pull request as ready for review June 21, 2023 17:44
@brlbil brlbil requested review from a team as code owners June 21, 2023 17:44
viktor-kurchenko
viktor-kurchenko approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brlbil brlbil added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Jun 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 22, 2023
@brlbil brlbil added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 22, 2023
@borkmann borkmann merged commit 3b69444 into main Jun 22, 2023
51 of 53 checks passed
@borkmann borkmann deleted the pr/brlbil/ci-fix-sysdump-names branch June 22, 2023 11:57
@brlbil brlbil mentioned this pull request Jun 22, 2023
Merged
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brlbil @viktor-kurchenko @borkmann