envoy: Re-organize supported envoy resource import #26469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is to lift and shift the import statements so that all the supported envoy protobuf resources are in one minimal package, and can be used for other projects. Signed-off-by: Tam Mach <tam.mach@cilium.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
area/proxy
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
sayboras
added a commit
to sayboras/cilium-cli
that referenced
this pull request
Jun 24, 2023
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Relates: cilium/cilium#26469 Signed-off-by: Tam Mach <tam.mach@cilium.io>
|
/test |
jrajahalme
approved these changes
Jun 28, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
added a commit
to sayboras/cilium-cli
that referenced
this pull request
Jun 28, 2023
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Relates: cilium/cilium#26469 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to sayboras/cilium-cli
that referenced
this pull request
Jun 30, 2023
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Relates: cilium/cilium#26469 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added a commit
to sayboras/cilium-cli
that referenced
this pull request
Jun 30, 2023
This is to avoid the similar happening again in the future, when we add more envoy resource types. Relates: cilium#1756 Relates: cilium/cilium#26469 Signed-off-by: Tam Mach <tam.mach@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to lift and shift the import statements so that all the supported envoy protobuf resources are in one minimal package, and can be used for other projects.