Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-verifier: run verifier tests directly on VM instead of containerized #26509

Merged
merged 1 commit into from Jun 27, 2023

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Jun 27, 2023

Partially revert 98cd4b2.

Partially revert 98cd4b2.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 27, 2023
@ti-mo ti-mo added the release-note/ci This PR makes changes to the CI. label Jun 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 27, 2023
@ti-mo
Copy link
Contributor Author

ti-mo commented Jun 27, 2023

Verifier tests passed: https://github.com/cilium/cilium/actions/runs/5390211168/jobs/9785286120. Rolling back 09c5799 and taking out of draft.

@ti-mo ti-mo force-pushed the tb/undockerize-verifier-tests branch from 09c5799 to e1c376e Compare June 27, 2023 14:08
@ti-mo ti-mo marked this pull request as ready for review June 27, 2023 14:08
@ti-mo ti-mo requested review from a team as code owners June 27, 2023 14:08
@ti-mo
Copy link
Contributor Author

ti-mo commented Jun 27, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 27, 2023
@joestringer joestringer merged commit 99190be into main Jun 27, 2023
65 checks passed
@joestringer joestringer deleted the tb/undockerize-verifier-tests branch June 27, 2023 17:47
tklauser added a commit to cilium/image-tools that referenced this pull request Jun 28, 2023
As of cilium/cilium#26509, we no longer use the
test-verifier image to run datapath verifier tests in CI. If any of the
tools previously contained in that image are needed, we should just use
the ones in the Cilium agent's image.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser added a commit to cilium/image-tools that referenced this pull request Jul 3, 2023
As of cilium/cilium#26509, we no longer use the
test-verifier image to run datapath verifier tests in CI. If any of the
tools previously contained in that image are needed, we should just use
the ones in the Cilium agent's image.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants