Skip to content

Commit

Permalink
Remove test-verifier image
Browse files Browse the repository at this point in the history
As of cilium/cilium#26509, we no longer use the
test-verifier image to run datapath verifier tests in CI. If any of the
tools previously contained in that image are needed, we should just use
the ones in the Cilium agent's image.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
  • Loading branch information
tklauser committed Jun 28, 2023
1 parent 61b26c7 commit dc7c793
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 54 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,6 @@ jobs:
with:
entrypoint: make
args: checkpatch-image PUSH=true
- uses: docker://quay.io/cilium/image-maker:e55375ca5ccaea76dc15a0666d4f57ccd9ab89de
name: Run make test-verifier-image
env:
DOCKER_HUB_PASSWORD: ${{ secrets.DOCKER_HUB_PASSWORD_CI }}
DOCKER_HUB_USERNAME: ${{ secrets.DOCKER_HUB_USERNAME_CI }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD_IMAGE_TOOLS }}
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME_IMAGE_TOOLS }}
with:
entrypoint: make
args: test-verifier-image PUSH=true
- uses: docker://quay.io/cilium/image-maker:e55375ca5ccaea76dc15a0666d4f57ccd9ab89de
name: Run make network-perf-image
env:
Expand Down
1 change: 0 additions & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@
/images/bpftool @cilium/loader
/images/checkpatch @cilium/sig-datapath
/images/llvm @cilium/loader
/images/test-verifier @cilium/loader
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ startup-script-image: .buildx_builder
checkpatch-image: .buildx_builder
PUSH=$(PUSH) EXPORT=$(EXPORT) scripts/build-image.sh cilium-checkpatch images/checkpatch linux/amd64,linux/arm64 "$$(cat .buildx_builder)" $(REGISTRIES)

test-verifier-image: .buildx_builder
PUSH=$(PUSH) EXPORT=$(EXPORT) scripts/build-image.sh test-verifier images/test-verifier linux/amd64,linux/arm64 "$$(cat .buildx_builder)" $(REGISTRIES)

network-perf-image: .buildx_builder
PUSH=$(PUSH) EXPORT=$(EXPORT) scripts/build-image.sh network-perf images/network-perf linux/amd64,linux/arm64 "$$(cat .buildx_builder)" $(REGISTRIES)

Expand Down
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ This image packages the [checkpatch.pl](images/checkpatch/checkpatch.pl) script

While the script itself is directly copied from [the upstream version in the kernel repository](https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl), a number of patches are applied before the script is run. These patch mostly address a number of false positives for Cilium's code base.

### [`images/test-verifier`](images/test-verifier/Dockerfile)

This image packages all the tools necessary to compile and load Cilium's BPF datapath, including Clang, bpftool, tc, ip, and gcc.

### [`images/tester`](images/tester/Dockerfile)

This image contains a [simple Go program](images/tester/cst/main.go), which is a minimal version of [`container-structure-test`](https://github.com/GoogleContainerTools/container-structure-test).
Expand Down
28 changes: 0 additions & 28 deletions images/test-verifier/Dockerfile

This file was deleted.

8 changes: 0 additions & 8 deletions images/test-verifier/README.md

This file was deleted.

0 comments on commit dc7c793

Please sign in to comment.