Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update KPR section on DSR #26582

Merged
merged 1 commit into from Jul 3, 2023
Merged

docs: update KPR section on DSR #26582

merged 1 commit into from Jul 3, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Jun 30, 2023 •
edited

Rephrase the DSR section to clarify the differences between the two dispatch mechanisms (IP option/extension, or Geneve option).

Fixes: #26339

@julianwiedmann julianwiedmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. area/loadbalancing Impacts load-balancing and Kubernetes service implementations needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jun 30, 2023
@julianwiedmann julianwiedmann marked this pull request as ready for review June 30, 2023 14:56
@julianwiedmann julianwiedmann requested review from a team as code owners June 30, 2023 14:56
@julianwiedmann julianwiedmann mentioned this pull request Jun 30, 2023
Closed
@julianwiedmann
docs: update KPR section on DSR
9ef31c1 
Rephrase the DSR section to clarify the differences between the two
dispatch mechanisms (IP option/extension, or Geneve option).

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
qmonnet
qmonnet approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qmonnet
Copy link
Member

qmonnet commented Jul 3, 2023

Doc change only, related workflow passed successfully, and Netlify preview builds OK. This is ready to merge.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 3, 2023
@borkmann borkmann merged commit 780c697 into cilium:main Jul 3, 2023
40 checks passed
@joamaki joamaki mentioned this pull request Jul 5, 2023
Merged
23 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 5, 2023
@julianwiedmann julianwiedmann deleted the 1.14-docs-dsr branch July 5, 2023 11:46
@jibi jibi added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 10, 2023
@joestringer joestringer mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@qmonnet qmonnet qmonnet approved these changes

@learnitall learnitall Awaiting requested review from learnitall learnitall is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/loadbalancing Impacts load-balancing and Kubernetes service implementations backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The DSR section in kubeproxy-free.rst may need to be updated
7 participants
@julianwiedmann @qmonnet @spacewander @ysksuzuki @jibi @borkmann @joamaki