Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specify Helm chart version in "cilium install" commands #26934

Merged
merged 1 commit into from Jul 21, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Jul 19, 2023

  • For the main branch latest docs, clone the Cilium GitHub repo and use
    "--chart-directory ./install/kubernetes/cilium" flag.
  • For stable branches, set "--version" flag to the version in the
    top-level VERSION file.

Fixes: #26931

Signed-off-by: Michi Mutsuzaki michi@isovalent.com

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 19, 2023
@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 19, 2023
@michi-covalent michi-covalent added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 19, 2023
@michi-covalent michi-covalent force-pushed the pr/michi/cilium-version-struggle branch 3 times, most recently from c09a72b to c263088 Compare July 19, 2023 21:42
@michi-covalent michi-covalent changed the title docs: Specify --version in "cilium install" commands docs: Specify Helm chart version in "cilium install" commands Jul 19, 2023
@michi-covalent michi-covalent force-pushed the pr/michi/cilium-version-struggle branch from c263088 to bfe4e60 Compare July 19, 2023 21:44
@michi-covalent michi-covalent marked this pull request as ready for review July 19, 2023 21:48
@michi-covalent michi-covalent requested review from a team as code owners July 19, 2023 21:48
@michi-covalent
Copy link
Contributor Author

travis ci: hit #26617

@michi-covalent
Copy link
Contributor Author

/test

Copy link
Member

@meyskens meyskens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me

Documentation/conf.py Outdated Show resolved Hide resolved
- For the main branch latest docs, clone the Cilium GitHub repo and use
 "--chart-directory ./install/kubernetes/cilium" flag.
- For stable branches, set "--version" flag to the version in the
  top-level VERSION file.

Fixes: #26931

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent force-pushed the pr/michi/cilium-version-struggle branch from bfe4e60 to af2ed5a Compare July 20, 2023 18:45
@michi-covalent
Copy link
Contributor Author

/test

@aanm
Copy link
Member

aanm commented Jul 20, 2023

@michi-covalent any reason why we can't backport this on all branches?

@michi-covalent
Copy link
Contributor Author

let's do it, i just wasn't sure how far to backport 🚀

@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jul 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.5 Jul 24, 2023
@nbusseneau nbusseneau mentioned this pull request Jul 24, 2023
21 tasks
@nbusseneau nbusseneau added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 24, 2023
@aanm aanm moved this from Needs backport from main to Backport done to v1.14 in 1.14.0 Jul 26, 2023
@gentoo-root gentoo-root added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jul 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.11 to Backport done to v1.11 in 1.11.19 Jul 26, 2023
@gentoo-root gentoo-root added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jul 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.5 Jul 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Needs backport from main in 1.12.12 Jul 26, 2023
@gentoo-root gentoo-root added this to Needs backport from main in 1.12.13 Jul 26, 2023
@gentoo-root gentoo-root removed this from Needs backport from main in 1.12.12 Jul 26, 2023
@julianwiedmann julianwiedmann added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jul 29, 2023
@asauber asauber moved this from Needs backport from main to Backport done to v1.12 in 1.12.13 Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.11.19
Backport done to v1.11
1.12.13
Backport done to v1.12
1.13.5
Backport done to v1.13
1.14.0
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

Make Cilium CLI installation method in the getting started guides have a --version like Helm
9 participants