New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Specify Helm chart version in "cilium install" commands #26934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Jul 19, 2023
michi-covalent
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Jul 19, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Jul 19, 2023
michi-covalent
added
the
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
label
Jul 19, 2023
michi-covalent
force-pushed
the
pr/michi/cilium-version-struggle
branch
3 times, most recently
from
July 19, 2023 21:42
c09a72b
to
c263088
Compare
michi-covalent
changed the title
docs: Specify --version in "cilium install" commands
docs: Specify Helm chart version in "cilium install" commands
Jul 19, 2023
michi-covalent
force-pushed
the
pr/michi/cilium-version-struggle
branch
from
July 19, 2023 21:44
c263088
to
bfe4e60
Compare
michi-covalent
requested review from
gentoo-root,
zacharysarah,
meyskens and
YutaroHayakawa
July 19, 2023 21:48
/test |
meyskens
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for me
gentoo-root
reviewed
Jul 20, 2023
- For the main branch latest docs, clone the Cilium GitHub repo and use "--chart-directory ./install/kubernetes/cilium" flag. - For stable branches, set "--version" flag to the version in the top-level VERSION file. Fixes: #26931 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/cilium-version-struggle
branch
from
July 20, 2023 18:45
bfe4e60
to
af2ed5a
Compare
gentoo-root
approved these changes
Jul 20, 2023
/test |
@michi-covalent any reason why we can't backport this on all branches? |
let's do it, i just wasn't sure how far to backport 🚀 |
nbusseneau
added
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
Jul 24, 2023
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.5
Jul 24, 2023
21 tasks
nbusseneau
added
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
and removed
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
labels
Jul 24, 2023
gentoo-root
added
backport-done/1.11
The backport for Cilium 1.11.x for this PR is done.
and removed
backport-pending/1.11
labels
Jul 26, 2023
maintainer-s-little-helper
bot
moved this from Backport pending to v1.11
to Backport done to v1.11
in 1.11.19
Jul 26, 2023
gentoo-root
added
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
and removed
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
labels
Jul 26, 2023
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.5
Jul 26, 2023
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Needs backport from main
in 1.12.12
Jul 26, 2023
This was referenced Jul 26, 2023
julianwiedmann
added
backport-done/1.12
The backport for Cilium 1.12.x for this PR is done.
and removed
backport-pending/1.12
labels
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.11
The backport for Cilium 1.11.x for this PR is done.
backport-done/1.12
The backport for Cilium 1.12.x for this PR is done.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"--chart-directory ./install/kubernetes/cilium" flag.
top-level VERSION file.
Fixes: #26931
Signed-off-by: Michi Mutsuzaki michi@isovalent.com