Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove systemd-based distributions issue from docs #27208

Merged
merged 1 commit into from Aug 7, 2023
Merged

remove systemd-based distributions issue from docs #27208

merged 1 commit into from Aug 7, 2023

Conversation

mate4st
Copy link
Contributor

@mate4st mate4st commented Aug 2, 2023

The issue with systemd is closed and supposed to be fixed in v1.14, therefore manually adjusting systemd should not be necessary anymore.

Fixes: #18706

@mate4st mate4st requested review from a team as code owners August 2, 2023 09:01
@maintainer-s-little-helper
Copy link

Commit bd871ff2fa39f3157158c499d48548f72b3a6af5 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 2, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 2, 2023
@mate4st mate4st changed the title remove systemd-based distributions issue remove systemd-based distributions issue from docs Aug 2, 2023
@dylandreimerink
Copy link
Member

The CI failed due to a temporary breakage in main, this has since been resolve, please rebase on main to fix the CI checks.

@mate4st
remove systemd-based distributions issue as
9950608 
Signed-off-by: Osthues <osthues.matthias@gmail.com>
@ldelossa
Copy link
Contributor

ldelossa commented Aug 3, 2023

Wondering if the doc should stay but instead be updated with the version of systemd where this error occurs and a note that it should no longer be an issue?

Not sure how quick distros bump their systemd versions, but I imagine slower distros like Debian may wait a bit?

@mate4st
Copy link
Contributor Author

mate4st commented Aug 3, 2023

If I understood correctly, this PR is meant to fix the problem for all systemd versions entirely? Maybe @NikAleksandrov can help us out here

@ldelossa
Copy link
Contributor

ldelossa commented Aug 3, 2023

Oh I miss understood this. I thought systemd the cause of an issue, not us.

@ldelossa ldelossa added the release-note/misc This PR makes changes that have no direct user impact. label Aug 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 3, 2023
@ldelossa
Copy link
Contributor

ldelossa commented Aug 3, 2023

Docs only change, no need to run full test suite.

@mate4st
Copy link
Contributor Author

mate4st commented Aug 4, 2023

Oh I miss understood this. I thought systemd the cause of an issue, not us.

That's true, but the PR mentioned above should make it work anyway. At least that's my understanding. Unfortunately I could not find anything about it in the release notes.

@joestringer joestringer added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Aug 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.1 Aug 7, 2023
joestringer
joestringer approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f29b435 went into v1.14.0, so we can backport this to v1.14 branch.

LGTM

@ldelossa ldelossa merged commit 0b1e3f7 into cilium:main Aug 7, 2023
40 checks passed
@joamaki joamaki mentioned this pull request Aug 8, 2023
Merged
9 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 8, 2023
@joamaki joamaki added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 9, 2023
@nebril nebril moved this from Needs backport from main to Backport done to v1.14 in 1.14.1 Aug 10, 2023
@nebril nebril mentioned this pull request Aug 10, 2023
Merged
onedr0p added a commit to onedr0p/cluster-template that referenced this pull request Dec 11, 2023
@onedr0p
fix: ManageForeignRoutes is not needed anymore
65bfe7a 
cilium/cilium#27208
arthurgeek pushed a commit to arthurgeek/home-k8s-k3s that referenced this pull request Dec 26, 2023
@onedr0p @arthurgeek
fix: ManageForeignRoutes is not needed anymore
69fef38 
cilium/cilium#27208
qlonik added a commit to qlonik/musical-parakeet that referenced this pull request Jan 11, 2024
@qlonik
chore: catch-up to template 1b73543d34dce0708621abdb180347634a355209
fb0e0f5 
* onedr0p/cluster-template@d854b89
  - fix: bump kps and prom operator crd versions
* onedr0p/cluster-template@840f388
  - fix(container): update image ghcr.io/kube-vip/kube-vip to v0.6.3
* onedr0p/cluster-template@9abcf47
  - fix: break out kps and cilium helm values into separate configmap in order
    to make renovate happy
* onedr0p/cluster-template@587c465
  - fix: name should be first in valuesFrom
* onedr0p/cluster-template@1975663
  - feat(container): update image kube-prometheus-stack to v51.3.0
* onedr0p/cluster-template@d93e1f6
  - fix: there are not aliases in YAML multi-line strings
* onedr0p/cluster-template@ddb3915
  - fix: remove secret on k8s dashboard ingress
* onedr0p/cluster-template@419116d
  - feat(container): update image kube-prometheus-stack to v51.4.0
* onedr0p/cluster-template@94d03e8
  - feat(container): update image kube-prometheus-stack to v51.6.1
* onedr0p/cluster-template@fe31e5d
  - feat(container): update image kube-prometheus-stack to v51.7.0
* onedr0p/cluster-template@4b91c5f
  - feat(container): update image kube-prometheus-stack to v51.8.1
* onedr0p/cluster-template@e449f61
  - feat(container): update image kube-prometheus-stack to v51.10.0
* onedr0p/cluster-template@a4642e6
  - fix: #990 don't disable apparmor unless it's installed
* onedr0p/cluster-template@04dabd4
  - feat(container)!: Update image kube-prometheus-stack to v52
* onedr0p/cluster-template@d9b515d
  - feat(container): update image kube-prometheus-stack to v52.1.0
* onedr0p/cluster-template@49c491b
  - feat: upgrade app-template charts to 2.0.3
* onedr0p/cluster-template@3f4bbb8
  - fix: use git source for k3s galaxy role
* onedr0p/cluster-template@70a3ced
  - chore: add calver release script
* onedr0p/cluster-template@eea1cdc
  - update template ingressClassName to className
* onedr0p/cluster-template@88cae95
  - feat(container): update image app-template to v2.2.0
* onedr0p/cluster-template@ab25928
  - fix: add back `spec.[install|upgrade].crds: CreateReplace` to kps helm
    release
* onedr0p/cluster-template@d0f4708
  - fix: upgrade bootstrap prom crd versions
* onedr0p/cluster-template@14051b1
  - feat(container)!: Update image kube-prometheus-stack to v54
* onedr0p/cluster-template@d0da98d
  - feat(container): update image kube-prometheus-stack to v54.1.0
* onedr0p/cluster-template@3ab157e
  - Update README.md
* onedr0p/cluster-template@fde77c3
  - feat(ansible): remove search domain from /etc/resolv.conf
* onedr0p/cluster-template@f47987c
  - fix: remove experimental Flux Helm drift detection
* onedr0p/cluster-template@787aed1
  - chore: add a pre-start checklist item
* onedr0p/cluster-template@521b08d
  - chore: englash is hard
* onedr0p/cluster-template@c870eae
  - feat(container): update image app-template to v2.3.0
* onedr0p/cluster-template@587ee70
  - feat(container): update image kube-prometheus-stack to v54.2.0
* onedr0p/cluster-template@30b4a88
  - Update cluster-rollout-update.yaml.j2
* onedr0p/cluster-template@30cccac
  - fix: remove dupe `when`
* onedr0p/cluster-template@fdff319
  - feat(k3s): enable encryption at rest and stargz snapshotter
* onedr0p/cluster-template@fc3c7b5
  - revert: "feat(k3s): enable encryption at rest and stargz snapshotter"
    stargz broken
* onedr0p/cluster-template@84574b2
  - feat!: Update Flux ks names and add volsync and snapshot-controller
* onedr0p/cluster-template@115e59e
  - feat: convert system-upgrade-controller to a helm chart
* onedr0p/cluster-template@8b23097
  - fix: templating error on volsync prom rules
* onedr0p/cluster-template@f85ba35
  - fix: update serviceaccount on system-upgrade-controller
* onedr0p/cluster-template@92f4a99
  - feat: move tehSUC into kube-system
* onedr0p/cluster-template@c7d8c2f
  - fix: renovate k3s builds numbers
* onedr0p/cluster-template@b5d5706
  - fix(container): update image kube-prometheus-stack to v54.2.2
* onedr0p/cluster-template@e9d3728
  - Fixed: topology for ingress-nginx instances due to labels not matching
* onedr0p/cluster-template@63edb13
  - fix: move renovate config into mono config file
* onedr0p/cluster-template@68b3e27
  - System Upgrade Controller install failed due to missing /etc/pki dir
    * System Upgrade Controller install failed due to missing /etc/pki directoy
      on host
    * Update SUC helmrelease.yaml.j2
      DirectoryOrCreate
    * Update cluster-prepare.yaml.j2
      Back out Previous Change
* onedr0p/cluster-template@924fa04
  - chore: update readme
* onedr0p/cluster-template@ae22b64
  - fix: add tolerations back to suc server plan
* onedr0p/cluster-template@6613f15
  - Add first attempt at devcontainer
* onedr0p/cluster-template@0f7623c
  - chore: update required python version to 3.10+
* onedr0p/cluster-template@08cea78
  - chore: add k8s and ansible config to vscode settings
* onedr0p/cluster-template@14bba07
  - chore: add ansible-lint
* onedr0p/cluster-template@ee81349
  - chore: add a task prompt on `task configure`
* onedr0p/cluster-template@fe56fa0
  - chore: fix task prompt spelling
* onedr0p/cluster-template@c749ff8
  - fix: add task for updating from the upstream template
* onedr0p/cluster-template@2a1e4a4
  - chore: add release file to exclude renovate from changelog
* onedr0p/cluster-template@4400029
  - chore: update devcontainer
* onedr0p/cluster-template@9d9c0bf
  - chore: update devcontainer
* onedr0p/cluster-template@7e8cb5b
  - chore: add SUC group to renovate config
* onedr0p/cluster-template@faec360
  - fix(helm): update chart snapshot-controller to 2.0.3
* onedr0p/cluster-template@de6bf19
  - chore: fix cf link in readme
* onedr0p/cluster-template@b5ff534
  - fix: run kube-vip playbook one node at a time
* onedr0p/cluster-template@e2d1831
  - chore: add flux-local mention in README
* onedr0p/cluster-template@e0a3a51
  - chore: update readme
* onedr0p/cluster-template@35eb6c8
  - fix(container): update image docker.io/rancher/kubectl to v1.28.4
* onedr0p/cluster-template@e660fba
  - fix: change attribute before deleting the file
* onedr0p/cluster-template@6be6e78
  - [bootstrap] fix: remove conflicting condition for immutable flag and
    state:absent
* onedr0p/cluster-template@ab174f8
  - [bootstrap] feat: target cluster ansible plays only to kubernetes in case
    other hosts are used
* onedr0p/cluster-template@f5857bb
  - feat: use official pause container because dockerhub sucks
* onedr0p/cluster-template@90eff07
  - feat: enable secrets encryption on k3s
* onedr0p/cluster-template@311863e
  - feat: allow overriding the default local-path-provisioner path for PVC data
* onedr0p/cluster-template@4cffc74
  - fix(container): update image ghcr.io/kube-vip/kube-vip to v0.6.4
* onedr0p/cluster-template@ae10897
  - feat(github-action)!: Update actions/labeler action to v5.0.0
* onedr0p/cluster-template@5d538a0
  - feat(container)!: Update image kube-prometheus-stack to v55
* onedr0p/cluster-template@3289bb2
  - Fixed required variable validation
* onedr0p/cluster-template@3b1a4e5
  - tweak README to specify an actual internal ingress with appropriate DNS
* onedr0p/cluster-template@123cdbf
  - Revert "Fixed required variable validation"
    This reverts commit 3289bb28b0a697ea5fc8e05da9b1ef35ba54ca80.
* onedr0p/cluster-template@a489ff2
  - chore: add new local path var to required vars and fix indenting
* onedr0p/cluster-template@03f39e9
  - [bootstrap] fix: Fixed required variable validation assertions
    * Fixed required variable validation
    * Fixed fix
* onedr0p/cluster-template@6496936
    - feat(container): update image kube-prometheus-stack to v55.1.0
* onedr0p/cluster-template@e504f61
  - chore: add admonishes to readme
* onedr0p/cluster-template@8dfc0c2
  - feat(container): update image app-template to v2.4.0
* onedr0p/cluster-template@929fdbd
  - fix: set permission for labeler workflow
* onedr0p/cluster-template@65bfe7a
  - fix: `ManageForeignRoutes` is not needed anymore
    cilium/cilium#27208
* onedr0p/cluster-template@bf28fba
  - fix: instead of defining modules twice just restart the modules-load service
* onedr0p/cluster-template@a374c72
  - fix: be a bit smarter when reloading kernel modules
* onedr0p/cluster-template@ab7a99a
  - feat: add bootstrap_cilium_loadbalancer_mode config option and default to
    dsr
* onedr0p/cluster-template@ebaccf6
  - chore: update `bootstrap_cilium_loadbalancer_mode` description comments
* onedr0p/cluster-template@429ef51
  - fix: missing name on cluster-rollout-update playbook
* onedr0p/cluster-template@f28e8fa
  - feat(container): update image kube-prometheus-stack to v55.3.1
* onedr0p/cluster-template@5ec1531
  - feat: update flux api versions for helmrelease
* onedr0p/cluster-template@8f95451
  - fix: update devcontainer base image
* onedr0p/cluster-template@bd2d784
  - fix(ansible): longhorn components are now a daemonset, no need to use the
    selector
* onedr0p/cluster-template@a0bf578
  - chore(ansible): clean up indentation
* onedr0p/cluster-template@de39a02
  - feat(container): update image kube-prometheus-stack to v55.5.0
* onedr0p/cluster-template@c07579d
  - feat(github-action)!: Update allenporter/flux-local action to 4.1.1
* onedr0p/cluster-template@7749154
  - feat(container): update image docker.io/rancher/kubectl to v1.29.0
* onedr0p/cluster-template@d44236a
  - feat(github-release): update k3s-io/k3s to v1.29.0+k3s1
* onedr0p/cluster-template@7fe5851
  - feat(github-action): update allenporter/flux-local action to 4.2.0
* onedr0p/cluster-template@a3fca06
  - chore: unpin gha in renovate and update link checker workflow
* onedr0p/cluster-template@80e95eb
  - chore: rename label related workflows
* onedr0p/cluster-template@eb4832d
  - chore: update the lychee workflow to be more smarter about finding the link
    checker issue
* onedr0p/cluster-template@100002e
  - chore: update lychee gh workflow to use CLI tool directly
* onedr0p/cluster-template@79c7dd7
  - fix: update fluxcd grafana dashboard URLs
* onedr0p/cluster-template@44da0c1
  - feat!: replace rancher/local-path-provisioner with democratic-csi in
    local-hostpath mode
* onedr0p/cluster-template@28390c9
  - chore: clean up yaml lang server comments
* onedr0p/cluster-template@15fe145
  - chore: update renovate config
* onedr0p/cluster-template@7058b3c
  - fix(github-action): update allenporter/flux-local action to 4.2.1
* onedr0p/cluster-template@6f7074a
  - fix(helm): update chart snapshot-controller to 2.0.4
* onedr0p/cluster-template@e44005c
  - chore: update workflows and remove token ref
* onedr0p/cluster-template@b045b12
  - fix: update flux-diff workflow to use container
* onedr0p/cluster-template@d02e7bf
  - fix: pin mshick/add-pr-comment to v2
* onedr0p/cluster-template@8aaa107
  - fix(container): update image kube-prometheus-stack to v55.5.1
* onedr0p/cluster-template@fa274a0
  - fix: lychee workflow results filepath
* onedr0p/cluster-template@494951e
  - chore: rename job steps in flux-diff
* onedr0p/cluster-template@4fd8f90
  - Set dev container Python version to 3.10.13
* onedr0p/cluster-template@642a4c9
  - Fix SOPS_AGE_KEY_FILE env variable in dev container
* onedr0p/cluster-template@5d4b0f5
  - Add direnv to dev container definition
* onedr0p/cluster-template@ec8c19a
  - feat!: for a single master node do not use etcd and add option to not use
    kube-vip
* onedr0p/cluster-template@4600467
  - chore: add important note in github webhook section
* onedr0p/cluster-template@a8bc633
  - chore: update readme
* onedr0p/cluster-template@e167882
  - feat!: refactor namespaces and add descheduler
* onedr0p/cluster-template@0c3bc58
  - fix: use SA created from helm chart for SUC
* onedr0p/cluster-template@9d3784e
  - fix: need raw jinja expressions for reloader now
* onedr0p/cluster-template@5ed3774
  - fix: update nuke playbook to run tasks directly
* onedr0p/cluster-template@1edb159
  - feat: replace stale-containers systemd timer with kubelet-args
* onedr0p/cluster-template@270f67a
  - fix: kube vip URL changed
* onedr0p/cluster-template@a19d708
  - Change back to output file
    * Change back to output file
      This was recently fixed in the new v1.9.0 action
    * fix: indent
    * remove token
    * revert to secret token
    * fix delete
    * remove extra lines
* onedr0p/cluster-template@f9a7307
  - feat: move installing prom operator crds to taskfile
* onedr0p/cluster-template@a7eadd3
  - feat!: refactor taskfiles and update README
* onedr0p/cluster-template@1b73543
  - feat(container): update image kube-prometheus-stack to v55.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@ldelossa ldelossa ldelossa approved these changes

@learnitall learnitall Awaiting requested review from learnitall learnitall is a code owner automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.1
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Host network broken after one of the underlying interfaces of a bond goes down
5 participants
@mate4st @dylandreimerink @ldelossa @joestringer @joamaki