New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Clean up prerequisites for the Ingress Controller #27222
Conversation
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qmonnet This is awesome. ✨ Minor formatting tweak, otherwise LGTM
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: kubeProxyReplacement=true is equivalent to the legacy strict mode, but not to the partial mode. It's likely that the full KPR is not necessary for running the Ingress Controller, but I wasn't able to find the exact subset of options that are required
Actually, partial along might not be enough, we also need enable-node-port
to complement.
@sayboras "Partial" does not exist anymore, we have "enabled" (formerly "strict") or disabled ("pick your options"). My question in this case, is, is it enough to have KPR "disabled" and In other words, what's the minimal requirement for Ingress support? |
Ah right, let me do a couple of tests locally and get back to you on this 👍 |
👋 sorry for the late reply, seems like the combination of kpr=false and nodePort.enabled=true is working for Ingress (except direct traffic to Ingress LB service nodeport). I have created #27304 to add coverage in CI so that we don't break this behavior unintentionally. Can you help to update the docs if possible, otherwise, I can send the follow-up PR?
|
This commit brings various minor improvements to the intro and prerequisites for the Ingress Controller documentation: - Add a link to Kubernetes' documentation for Ingress, given that we never define or explain what Kubernetes Ingress is - Instruct users to "enable" kube-proxy replacement, given that the values "strict" or "partial" are deprecated. - Mention NodePort as an alternative to kube-proxy replacement, givent that this is the only feature from KPR which is actually required for Ingress. - Use the Helm value instead of the agent flag for the L7 proxy configuration, simply to remain consistent with the item above (KPR). - Remove the requirement on Kubernetes 1.19+, given that 1.19 is now the minimum version supported by Cilium. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and LGTM ✅
@sayboras: Thanks! Grepping for [Edit: see directly PR linked below.] |
Review addressed, “otherwise LGTM”
This commit brings various minor improvements to the intro and prerequisites for the Ingress Controller documentation:
NOTE:
kubeProxyReplacement=true
is equivalent to the legacystrict
mode, but not to thepartial
mode. It's likely that the full KPR is not necessary for running the Ingress Controller, but I wasn't able to find the exact subset of options that are required. @sayboras (you authored this requirement in the first place), do you know?