Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress: Add conformance test for KPR=false #27304

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Aug 6, 2023

This is to test the combination of kubeProxyReplacement=false, but with nodePort.enabled=true.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 6, 2023
@sayboras sayboras added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Aug 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 6, 2023
@sayboras sayboras force-pushed the tam/nodeport-ingress-gw-api branch from af1f740 to 911a473 Compare August 6, 2023 11:11
@sayboras
Copy link
Member Author

sayboras commented Aug 6, 2023

/ci-ingress

@sayboras sayboras force-pushed the tam/nodeport-ingress-gw-api branch from 911a473 to 1eb9428 Compare August 6, 2023 11:23
@sayboras
Copy link
Member Author

sayboras commented Aug 6, 2023

/ci-ingress

@sayboras sayboras marked this pull request as ready for review August 6, 2023 11:31
@sayboras sayboras requested review from a team as code owners August 6, 2023 11:31
This is to test the combination of kubeProxyReplacement=false, but with
nodePort.enabled=true. One limitation is that the direct traffic from LB
service nodeport will not be redirected to Envoy proxy.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the tam/nodeport-ingress-gw-api branch from 1eb9428 to 9fe1597 Compare August 6, 2023 15:50
@sayboras
Copy link
Member Author

sayboras commented Aug 6, 2023

/test

Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sayboras sayboras merged commit 77184ed into main Aug 7, 2023
178 checks passed
@sayboras sayboras deleted the tam/nodeport-ingress-gw-api branch August 7, 2023 08:58
@qmonnet qmonnet added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Sep 8, 2023
@tklauser tklauser added needs-backport/1.13 needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 13, 2023
@tklauser tklauser removed needs-backport/1.13 needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 13, 2023
@julianwiedmann julianwiedmann added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 labels Sep 14, 2023
marseel added a commit to marseel/cilium that referenced this pull request Oct 2, 2024
Currently, we were skipping internal to NodePort test for all matrix
entries.

Fixes: cilium#27304

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
marseel added a commit to marseel/cilium that referenced this pull request Oct 2, 2024
Currently, we were skipping internal to NodePort test for all matrix
entries.

Fixes: cilium#27304

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
marseel added a commit that referenced this pull request Oct 2, 2024
Currently, we were skipping internal to NodePort test for all matrix
entries.

Fixes: #27304

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
github-merge-queue bot pushed a commit that referenced this pull request Oct 4, 2024
Currently, we were skipping internal to NodePort test for all matrix
entries.

Fixes: #27304

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Status: Released
Development

Successfully merging this pull request may close these issues.

5 participants