Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Rename workflow names #27391

Merged
merged 1 commit into from Aug 25, 2023
Merged

CI: Rename workflow names #27391

merged 1 commit into from Aug 25, 2023

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Aug 9, 2023 •
edited

This commit changes the workflow's name fields to make them more human-readable by adding spaces.
Also, some of the names were changed to be more consistent with each other.

@brlbil brlbil requested review from a team as code owners August 9, 2023 14:07
@brlbil brlbil requested a review from nbusseneau August 9, 2023 14:08
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 9, 2023
@brlbil brlbil marked this pull request as draft August 9, 2023 14:15
@brlbil brlbil force-pushed the pr/brlbil/ci-rename-workflows branch from d2df66a to f94d984 Compare August 11, 2023 14:26
@brlbil brlbil added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Aug 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 11, 2023
@brlbil
Copy link
Contributor Author

brlbil commented Aug 11, 2023

/test

@brlbil brlbil marked this pull request as ready for review August 11, 2023 14:33
@brlbil brlbil requested a review from a team as a code owner August 11, 2023 14:33
@brlbil brlbil added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.13 Aug 12, 2023
@asauber asauber added this to Needs backport from main in 1.12.14 Aug 13, 2023
@asauber asauber removed this from Needs backport from main in 1.12.13 Aug 13, 2023
nbusseneau
nbusseneau reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added some comments below on general strategy, can do another pass later on specifics.

.github/workflows/build-images-base.yaml Show resolved Hide resolved
.github/workflows/conformance-clustermesh.yaml Show resolved Hide resolved
.github/workflows/conformance-e2e.yaml Show resolved Hide resolved
@brlbil brlbil force-pushed the pr/brlbil/ci-rename-workflows branch from f94d984 to 5e69b54 Compare August 17, 2023 16:09
@brlbil brlbil requested a review from a team as a code owner August 17, 2023 16:09
@brlbil brlbil requested a review from nebril August 17, 2023 16:09
nebril
nebril approved these changes Aug 18, 2023
View reviewed changes
.github/workflows/build-images-beta.yaml Show resolved Hide resolved
.github/workflows/build-images-ci.yaml Show resolved Hide resolved
.github/workflows/build-images-releases.yaml Show resolved Hide resolved
@brlbil
ci: rename name fields
df0d946 
This commit changes workflow's name fields to
make them more human readable by adding spaces.
Also some of the names was changed to be more consistent with each other

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-rename-workflows branch from 5e69b54 to df0d946 Compare August 24, 2023 14:11
@brlbil
Copy link
Contributor Author

brlbil commented Aug 25, 2023

/test

@borkmann borkmann deleted the pr/brlbil/ci-rename-workflows branch August 25, 2023 13:28
@joestringer
Copy link
Member

@brlbil @nbusseneau how do we ensure consistency over time for these? I would like to avoid making rename changes like this as much as possible in future due to the disruption to PRs (renaming => have to rebase and rerun CI for every PR). Every time we create a new CI job there is a risk that we'll deviate again and then later on end up submitting a change again. We are still periodically adding more CI jobs. Is this something that @cilium/ci-structure will now enforce?

@nbusseneau
Copy link
Member

I think yes, the right way forward would be to be stricter when doing reviews.

@pippolo84 pippolo84 mentioned this pull request Aug 28, 2023
Merged
9 tasks
@pippolo84 pippolo84 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.2 Aug 28, 2023
@pippolo84 pippolo84 mentioned this pull request Aug 28, 2023
Merged
3 tasks
@pippolo84 pippolo84 added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Aug 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.7 Aug 28, 2023
@pippolo84 pippolo84 mentioned this pull request Aug 28, 2023
Merged
2 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.14 Aug 28, 2023
This was referenced Aug 31, 2023
Merged
Closed
@michi-covalent michi-covalent added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.14 to Backport done to v1.14 in 1.14.2 Sep 9, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
@michi-covalent michi-covalent added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Sep 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.7 Sep 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.7 Sep 9, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
@michi-covalent michi-covalent added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Sep 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.14 Sep 9, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbusseneau nbusseneau nbusseneau left review comments

@gentoo-root gentoo-root gentoo-root approved these changes

@nebril nebril nebril approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.12.14
Backport done to v1.12
1.13.7
Backport done to v1.13
1.14.2
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@brlbil @joestringer @nbusseneau @gentoo-root @nebril @aanm @borkmann @pippolo84 @michi-covalent