Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix missing names #27839

Merged
merged 1 commit into from
Sep 1, 2023
Merged

CI: fix missing names #27839

merged 1 commit into from
Sep 1, 2023

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Aug 31, 2023 •
edited

This PR fixes name fields that are not handled with #27391
Also, it adds a lint job to check for Jobs and Steps without a name

These issues were fixed during the backport process to stable branches.

Branch protection rules need to be adjusted.
To Remove

coccicheck

To Add

BPF Checks / Run coccicheck

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 31, 2023
@brlbil
ci: fix missing names
9507a1b 
This commit fixes name fields that is not handled with e9e43fe
Also, it adds lint job to check for Jobs and Steps without a name

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil
Copy link
Contributor Author

brlbil commented Aug 31, 2023

/test

@brlbil brlbil marked this pull request as ready for review August 31, 2023 08:09
@brlbil brlbil requested review from a team as code owners August 31, 2023 08:09
@brlbil brlbil requested a review from nbusseneau August 31, 2023 08:09
@brlbil brlbil added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Aug 31, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 31, 2023
@brlbil
Copy link
Contributor Author

brlbil commented Aug 31, 2023

Branch protection rule coccicheck is changed so it is not reported, setting as ready-to-merge

@brlbil brlbil added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 31, 2023
@brlbil brlbil mentioned this pull request Aug 31, 2023
Closed
@borkmann borkmann merged commit f3c7023 into main Sep 1, 2023
200 checks passed
@borkmann borkmann deleted the pr/brlbil/ci-fix-names branch September 1, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brlbil @nbusseneau @borkmann